Re: [PATCH v3 31/33] global: Rename SPL_TPL_ to PHASE_

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1185 bytes --]

On Sun, Sep 29, 2024 at 07:49:54PM -0600, Simon Glass wrote:

> Use PHASE_ as the symbol to select a particular XPL build. This means
> that SPL_TPL_ is no-longer set.
> 
> Update the comment in bootstage to refer to this symbol, instead of
> SPL_
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>
[snip]
> diff --git a/common/bootstage.c b/common/bootstage.c
> index dca33148192..dd6aed7c2fd 100644
> --- a/common/bootstage.c
> +++ b/common/bootstage.c
> @@ -351,7 +351,7 @@ void bootstage_report(void)
>  	}
>  	if (data->rec_count > RECORD_COUNT)
>  		printf("Overflowed internal boot id table by %d entries\n"
> -		       "Please increase CONFIG_(SPL_TPL_)BOOTSTAGE_RECORD_COUNT\n",
> +		       "Please increase CONFIG_(PHASE_)BOOTSTAGE_RECORD_COUNT\n",
>  		       data->rec_count - RECORD_COUNT);
>  
>  	puts("\nAccumulated time:\n");

This is a 2 byte rodata reduction because we change the constant string
to be shorter. Perhaps this (and the later debug() message) should be
reworked to read:
"Please increase BOOTSTAGE_RECORD_COUNT for this phase\n"
which is hopefully enough of a crumb to lead someone to the right CONFIG
option?

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]