Re: [PATCH v3 06/33] stdio: Make use of the SERIAL define

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1118 bytes --]

On Sun, Sep 29, 2024 at 07:49:29PM -0600, Simon Glass wrote:
> This is always enabled for U-Boot proper, so simplify the condition
> in the common Makefile.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
> 
> Changes in v3:
> - Move earlier in the series
> 
>  include/stdio.h | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/include/stdio.h b/include/stdio.h
> index 7b999a519ba..e7325795533 100644
> --- a/include/stdio.h
> +++ b/include/stdio.h
> @@ -9,10 +9,7 @@ int getchar(void);
>  int tstc(void);
>  
>  /* stdout */
> -#if !defined(CONFIG_SPL_BUILD) || \
> -	(defined(CONFIG_TPL_BUILD) && defined(CONFIG_TPL_SERIAL)) || \
> -	(defined(CONFIG_SPL_BUILD) && !defined(CONFIG_TPL_BUILD) && \
> -		defined(CONFIG_SPL_SERIAL))
> +#if !defined(CONFIG_SPL_BUILD) || CONFIG_IS_ENABLED(SERIAL)
>  void putc(const char c);
>  void puts(const char *s);
>  #ifdef CONFIG_CONSOLE_FLUSH_SUPPORT

There was, earlier on, reason for this level of complexity but it indeed
seems no longer required.

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]