Re: [PATCH v6 14/37] efi_loader: Allocate and write ACPI tables

Simon Glass
2024-10-03T20:46:22Z

Hi Ilias,

On Thu, 3 Oct 2024 at 09:59, Ilias Apalodimas
<ilias.apalodimas@linaro.org> wrote:
>
> Hi Simon,
>
> On Thu, 3 Oct 2024 at 16:49, Simon Glass <sjg@chromium.org> wrote:
> >
> > Hi Ilias,
> >
> > On Wed, 2 Oct 2024 at 23:45, Ilias Apalodimas
> > <ilias.apalodimas@linaro.org> wrote:
> > >
> > > Hi Patrick,
> > >
> > > We've been back and forth on this, but we still disagree on the
> > > allocations etc, but I don't think it's that important to keep the
> > > patch out due to this.
> > >
> > > Can we move the table generation to the ACPI subsystem?
> > > efi_acpi_register() will convert the memory as needed, so I was
> > > wondering why the creation itself can't be done there. If you simply
> > > fill table_start_high/table_end_hi, EFI will install the config tables
> > > properly
> >
> > Yes, that's a good idea. The whole function can just move to
> > lib/acpi/acpi_writer.c perhaps?
>
> I haven't chedk the ACPI stuff to have an opinion. The description on
> that file matches that

Yes.

Patrick, please can you rebase on -next as well?

Regards,
Simon