public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Tom Rini <trini@konsulko.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	u-boot@lists.denx.de
Cc: Simon Glass <sjg@chromium.org>, Bin Meng <bmeng.cn@gmail.com>
Subject: [PATCH v1 2/4] x86: cpu: Mark a few functions static
Date: Sat,  5 Oct 2024 22:11:58 +0300	[thread overview]
Message-ID: <20241005191353.1927660-3-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20241005191353.1927660-1-andriy.shevchenko@linux.intel.com>

Some functions are not used anywhere except the same file
where they are defined. Mark them static. This helps avoiding
the compiler warnings:

  arch/x86/cpu/cpu.c:343:6: warning: no previous prototype for ‘detect_coreboot_table_at’ [-Wmissing-prototypes]
  arch/x86/cpu/mtrr.c:90:6: warning: no previous prototype for ‘mtrr_write_all’ [-Wmissing-prototypes]
  arch/x86/cpu/i386/interrupt.c:240:6: warning: no previous prototype for ‘__do_irq’ [-Wmissing-prototypes]

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 arch/x86/cpu/cpu.c            | 2 +-
 arch/x86/cpu/i386/interrupt.c | 2 +-
 arch/x86/cpu/mtrr.c           | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/x86/cpu/cpu.c b/arch/x86/cpu/cpu.c
index 3aa35b811b36..e9300709347e 100644
--- a/arch/x86/cpu/cpu.c
+++ b/arch/x86/cpu/cpu.c
@@ -340,7 +340,7 @@ int reserve_arch(void)
 }
 #endif
 
-long detect_coreboot_table_at(ulong start, ulong size)
+static long detect_coreboot_table_at(ulong start, ulong size)
 {
 	u32 *ptr, *end;
 
diff --git a/arch/x86/cpu/i386/interrupt.c b/arch/x86/cpu/i386/interrupt.c
index b3f4214acdb7..6f78b072cde5 100644
--- a/arch/x86/cpu/i386/interrupt.c
+++ b/arch/x86/cpu/i386/interrupt.c
@@ -237,7 +237,7 @@ void *x86_get_idt(void)
 	return &idt_ptr;
 }
 
-void __do_irq(int irq)
+static void __do_irq(int irq)
 {
 	printf("Unhandled IRQ : %d\n", irq);
 }
diff --git a/arch/x86/cpu/mtrr.c b/arch/x86/cpu/mtrr.c
index 50cba5fb88dc..07ea89162dee 100644
--- a/arch/x86/cpu/mtrr.c
+++ b/arch/x86/cpu/mtrr.c
@@ -87,7 +87,7 @@ void mtrr_read_all(struct mtrr_info *info)
 	}
 }
 
-void mtrr_write_all(struct mtrr_info *info)
+static void mtrr_write_all(struct mtrr_info *info)
 {
 	int reg_count = mtrr_get_var_count();
 	struct mtrr_state state;
-- 
2.43.0.rc1.1336.g36b5255a03ac


  parent reply	other threads:[~2024-10-05 19:14 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-05 19:11 [PATCH v1 0/4] x86: Clean up and fix to avoid compiler warnings Andy Shevchenko
2024-10-05 19:11 ` [PATCH v1 1/4] x86: cpu: Use default print_cpuinfo() for all Andy Shevchenko
2024-10-09  1:56   ` Simon Glass
2024-10-09 14:06     ` Andy Shevchenko
2024-10-09 21:14       ` Simon Glass
2024-10-17 23:11         ` Simon Glass
2024-10-05 19:11 ` Andy Shevchenko [this message]
2024-10-09  1:56   ` [PATCH v1 2/4] x86: cpu: Mark a few functions static Simon Glass
2024-10-17 23:11     ` Simon Glass
2024-10-05 19:11 ` [PATCH v1 3/4] x86: cpu: Add a few prototypes to the header file Andy Shevchenko
2024-10-09  1:55   ` Simon Glass
2024-10-09 14:07     ` Andy Shevchenko
2024-10-09 21:14       ` Simon Glass
2024-10-17 23:11         ` Simon Glass
2024-10-18 11:43           ` Andy Shevchenko
2024-10-18 14:55             ` Simon Glass
2024-10-18 15:56               ` Andy Shevchenko
2024-10-05 19:12 ` [PATCH v1 4/4] x86: cpu: Add missing header inclusion Andy Shevchenko
2024-10-09  1:55   ` Simon Glass
2024-10-17 23:11     ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241005191353.1927660-3-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=bmeng.cn@gmail.com \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox