Re: [PATCH v1] imx: Kconfig: make IMX8_ROMAPI configurable

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1429 bytes --]

On Mon, Oct 07, 2024 at 12:28:44AM +0200, Marek Vasut wrote:
> On 10/6/24 11:23 PM, Tom Rini wrote:
> > On Sun, Oct 06, 2024 at 07:31:16AM +0800, alice.guo@oss.nxp.com wrote:
> > 
> > > From: Peng Fan <peng.fan@nxp.com>
> > > 
> > > Make CONFIG_IMX8_ROMAPI could be configured in defconfig.
> > > 
> > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > Signed-off-by: Alice Guo <alice.guo@nxp.com>
> > > Reviewed-by: Ye Li <ye.li@nxp.com>
> > > ---
> > >   arch/arm/mach-imx/Kconfig | 3 ++-
> > >   1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> > > index 134e42028c..9d3aafd2f8 100644
> > > --- a/arch/arm/mach-imx/Kconfig
> > > +++ b/arch/arm/mach-imx/Kconfig
> > > @@ -179,7 +179,8 @@ config DDRMC_VF610_CALIBRATION
> > >   	  the ddrmc_cr_setting on relevant board file.
> > >   config IMX8_ROMAPI
> > > -	def_bool y
> > > +	bool "Enable i.MX ROMAPI"
> > > +	default y
> > >   	depends on IMX8MN || IMX8MP || IMX8ULP || IMX9
> > 
> > Since there's no help here, is this truly configurable, or is this
> > something that should be select'd based on the SoC and presumably some
> > of the newer IMX9 parts cannot use this?
> I can imagine the MX95 calls into this custom ELE firmware stuff instead of
> ROMAPI ?

Alright. Perhaps this should be depending on the above and
!main-ELE-symbol instead.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]