* [PATCH v1] scmi_protocols: Update discover list protocol message
@ 2024-10-06 9:50 alice.guo
2024-10-07 17:04 ` Tom Rini
0 siblings, 1 reply; 3+ messages in thread
From: alice.guo @ 2024-10-06 9:50 UTC (permalink / raw)
To: u-boot
Cc: trini, alice.guo, ye.li, peng.fan, akashi.tkhro, sjg, festevam,
marex
From: Ye Li <ye.li@nxp.com>
When work with System Manager, System Manager provides vendor specific
protocol, so the protocol array size is not enough.
Signed-off-by: Ye Li <ye.li@nxp.com>
Signed-off-by: Alice Guo <alice.guo@nxp.com>
---
include/scmi_protocols.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/scmi_protocols.h b/include/scmi_protocols.h
index 43b66be00a..6204ce076e 100644
--- a/include/scmi_protocols.h
+++ b/include/scmi_protocols.h
@@ -146,7 +146,7 @@ struct scmi_base_discover_impl_version_out {
struct scmi_base_discover_list_protocols_out {
s32 status;
u32 num_protocols;
- u32 protocols[3];
+ u32 protocols[4];
};
/**
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v1] scmi_protocols: Update discover list protocol message
2024-10-06 9:50 [PATCH v1] scmi_protocols: Update discover list protocol message alice.guo
@ 2024-10-07 17:04 ` Tom Rini
2024-10-07 17:49 ` Fabio Estevam
0 siblings, 1 reply; 3+ messages in thread
From: Tom Rini @ 2024-10-07 17:04 UTC (permalink / raw)
To: alice.guo
Cc: u-boot, alice.guo, ye.li, peng.fan, akashi.tkhro, sjg, festevam,
marex
[-- Attachment #1: Type: text/plain, Size: 1024 bytes --]
On Sun, Oct 06, 2024 at 05:50:22PM +0800, alice.guo@oss.nxp.com wrote:
> From: Ye Li <ye.li@nxp.com>
>
> When work with System Manager, System Manager provides vendor specific
> protocol, so the protocol array size is not enough.
>
> Signed-off-by: Ye Li <ye.li@nxp.com>
> Signed-off-by: Alice Guo <alice.guo@nxp.com>
> ---
> include/scmi_protocols.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/scmi_protocols.h b/include/scmi_protocols.h
> index 43b66be00a..6204ce076e 100644
> --- a/include/scmi_protocols.h
> +++ b/include/scmi_protocols.h
> @@ -146,7 +146,7 @@ struct scmi_base_discover_impl_version_out {
> struct scmi_base_discover_list_protocols_out {
> s32 status;
> u32 num_protocols;
> - u32 protocols[3];
> + u32 protocols[4];
> };
>
> /**
Changing a constant from 3 to 4 isn't good, please define something and
add a comment explaining what the constant means so it'll be clear
when/why someone changes it to 5. Thanks.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v1] scmi_protocols: Update discover list protocol message
2024-10-07 17:04 ` Tom Rini
@ 2024-10-07 17:49 ` Fabio Estevam
0 siblings, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2024-10-07 17:49 UTC (permalink / raw)
To: Tom Rini
Cc: alice.guo, u-boot, alice.guo, ye.li, peng.fan, akashi.tkhro, sjg,
marex
Hi Alice and NXP folks,
> Changing a constant from 3 to 4 isn't good, please define something and
> add a comment explaining what the constant means so it'll be clear
> when/why someone changes it to 5. Thanks.
Please improve all the commit messages from the recent patches.
All patches need a clear commit log explaining the
motivation/rationale for the change.
The recent patches have poor commit messages and we cannot take them as-is.
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-07 17:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-06 9:50 [PATCH v1] scmi_protocols: Update discover list protocol message alice.guo
2024-10-07 17:04 ` Tom Rini
2024-10-07 17:49 ` Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox