Re: [PATCH v1] scmi_protocols: Update discover list protocol message

Tom Rini
2024-10-07T17:04:59Z

[-- Attachment #1: Type: text/plain, Size: 1024 bytes --]

On Sun, Oct 06, 2024 at 05:50:22PM +0800, alice.guo@oss.nxp.com wrote:
> From: Ye Li <ye.li@nxp.com>
>
> When work with System Manager, System Manager provides vendor specific
> protocol, so the protocol array size is not enough.
>
> Signed-off-by: Ye Li <ye.li@nxp.com>
> Signed-off-by: Alice Guo <alice.guo@nxp.com>
> ---
> include/scmi_protocols.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/scmi_protocols.h b/include/scmi_protocols.h
> index 43b66be00a..6204ce076e 100644
> --- a/include/scmi_protocols.h
> +++ b/include/scmi_protocols.h
> @@ -146,7 +146,7 @@ struct scmi_base_discover_impl_version_out {
> struct scmi_base_discover_list_protocols_out {
> s32 status;
> u32 num_protocols;
> - u32 protocols[3];
> + u32 protocols[4];
> };
>
> /**

Changing a constant from 3 to 4 isn't good, please define something and
add a comment explaining what the constant means so it'll be clear
when/why someone changes it to 5. Thanks.

--
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]