From: Alex Shumsky <alexthreed@gmail.com>
To: u-boot@lists.denx.de
Cc: Alex Shumsky <alexthreed@gmail.com>,
Ben Wolsieffer <benwolsieffer@gmail.com>,
Chris Morgan <macromorgan@hotmail.com>,
Dragan Simic <dsimic@manjaro.org>,
Jonas Karlman <jonas@kwiboo.se>,
Kever Yang <kever.yang@rock-chips.com>,
Marek Vasut <marex@denx.de>,
Philipp Tomsich <philipp.tomsich@theobroma-systems.com>,
Philipp Tomsich <philipp.tomsich@vrull.eu>,
Quentin Schulz <quentin.schulz@cherry.de>,
Simon Glass <sjg@chromium.org>, Tom Rini <trini@konsulko.com>
Subject: [PATCH v2] rockchip: board: Increase rng-seed size to make it sufficient for modern Linux
Date: Mon, 14 Oct 2024 20:53:38 +0300 [thread overview]
Message-ID: <20241014175338.2675136-1-alexthreed@gmail.com> (raw)
Modern Linux requires 32 byte seed to initialize random pool, but u-boot
currently provides only 8 bytes. Increase rng-seed size to make Linux happy and
initialize rng pool instantly.
Boot with 8 byte rng-seed:
# dmesg | grep crng
[ 12.089286] random: crng init done
Boot with 32 byte rng-seed:
# dmesg | grep crng
[ 0.000000] random: crng init done
https://github.com/torvalds/linux/blob/7234e2ea0edd00bfb6bb2159e55878c19885ce68/drivers/char/random.c#L632
Signed-off-by: Alex Shumsky <alexthreed@gmail.com>
Fixes: d2048bafae40 ("rockchip: board: Add board_rng_seed() for all Rockchip devices")
---
Changes in v2:
- add env config knob rng_seed_size
- 12-character commit SHA in Fixes
arch/arm/mach-rockchip/board.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-rockchip/board.c b/arch/arm/mach-rockchip/board.c
index 3fadf7e412..f9f0d7214c 100644
--- a/arch/arm/mach-rockchip/board.c
+++ b/arch/arm/mach-rockchip/board.c
@@ -472,9 +472,15 @@ __weak int misc_init_r(void)
__weak int board_rng_seed(struct abuf *buf)
{
struct udevice *dev;
- size_t len = 0x8;
+ ulong len = env_get_ulong("rng_seed_size", 10, 32);
u64 *data;
+ if (len < 32) {
+ // rng_seed_size should be 32 bytes for Linux 5.19+, or 64 for older Linux'es
+ log_warning("Too small rng_seed_size (%lu). It is likely insufficient to init linux crng\n",
+ len);
+ }
+
data = malloc(len);
if (!data) {
printf("Out of memory\n");
--
2.34.1
next reply other threads:[~2024-10-14 17:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 17:53 Alex Shumsky [this message]
2024-10-14 18:19 ` [PATCH v2] rockchip: board: Increase rng-seed size to make it sufficient for modern Linux Dragan Simic
2024-10-14 18:50 ` Alex ThreeD
2024-10-14 19:00 ` Dragan Simic
2024-10-14 19:17 ` Alex ThreeD
2024-10-14 19:28 ` Dragan Simic
2024-10-14 20:12 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241014175338.2675136-1-alexthreed@gmail.com \
--to=alexthreed@gmail.com \
--cc=benwolsieffer@gmail.com \
--cc=dsimic@manjaro.org \
--cc=jonas@kwiboo.se \
--cc=kever.yang@rock-chips.com \
--cc=macromorgan@hotmail.com \
--cc=marex@denx.de \
--cc=philipp.tomsich@theobroma-systems.com \
--cc=philipp.tomsich@vrull.eu \
--cc=quentin.schulz@cherry.de \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox