Re: [PATCH 13/17] imx: Kconfig: IMX8_ROMAPI is not configured for i.MX95

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1243 bytes --]

On Wed, Oct 16, 2024 at 03:18:06PM +0800, Alice Guo wrote:
> From: Alice Guo <alice.guo@nxp.com>
> 
> i.MX95 only supports low power boot, which means A55 is kicked by M33.
> There is no ROM runs on A55 in such case so that deselect IMX8_ROMAPI
> for i.MX95.
> 
> Signed-off-by: Alice Guo <alice.guo@nxp.com>
> ---
>  arch/arm/mach-imx/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> index 134e42028c3787d78e28af03d40c41a8b2b1981b..56577b9ade349740b6d98ab933797d7072985de0 100644
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -179,7 +179,7 @@ config DDRMC_VF610_CALIBRATION
>  	  the ddrmc_cr_setting on relevant board file.
>  
>  config IMX8_ROMAPI
> -	def_bool y
> +	def_bool y if (!IMX95)
>  	depends on IMX8MN || IMX8MP || IMX8ULP || IMX9
>  
>  config SPL_IMX_ROMAPI_LOADADDR

If we're going to add parens here, it should be:
depends on IMX8MN || IMX8MP || IMX8ULP || (IMX9 && !IMX95)

And if down the line there's more IMX9 exclusions, the i.MX9 family that
does use this needs it own symbol so it can be here just like how all of
the i.MX8 families are spelled out, thanks.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]