Re: [PATCH 0/5] collected fallout of porting an ATSAMA5D27 based board

[Alexander Dahl <ada@thorsis.com>]

Hello Benedikt,

Am Fri, Oct 18, 2024 at 10:30:00AM +0200 schrieb Benedikt Spranger:
> Hi,
> 
> while porting an ATSAMA5D2 based board (booting from NAND flash with UBI)
> I stumbled over generic, NAND- and UBI related asperity:
> 
> 1. tiny-printf does not handle NULL arguments to '%s' in a proper way
> 2. vtbl_check() has an useless debug output due to a typo
> 3. NAND: An informative output fails badly, if the NAND vendor is unknown
> 4. the nand_atmel driver lacks a vital initialisation
> 
> OK, you might say the nand_atmel NAND driver is obsolete, but it was the
> only solution to get booting from NAND running. The new DM based NAND driver
> refused to do anything usefull, so I dropped it after spending a couple of
> days debugging it:

Strange.  I have at least three different boards with SAMA5D27
successfully booting from NAND flash with the new DM based driver
(unfortunately none of them upstreamed, which also won't change in the
foreseeable future, sorry).

Do you use at91bootstrap as 2nd level bootloader like me or something
else?  For me it was basically getting the dts for U-Boot correct, but
I got that running with all U-Boot releases since 2023.04 up to
2024.10.  Could you share some more detail?

> <RANT>brilliant!</RANT>

Did you talk with Microchip about it?

Greets
Alex

> 
> 
> 
> regards
>     Benedikt Spranger
> 
> Benedikt Spranger (5):
>   tiny-printf: Handle NULL pointer argument to %s
>   drivers/mtd/ubispl/ubispl.c: Fix error message
>   mtd: nand: raw: Fix potential NULL pointer dereference
>   mtd: nand: Update NAND manufacturer Ids
>   mtd: nand: raw: atmel_nand: Add missing nand_scan_ident()
> 
>  drivers/mtd/nand/raw/atmel_nand.c |  4 ++++
>  drivers/mtd/nand/raw/nand_base.c  |  8 ++++----
>  drivers/mtd/nand/raw/nand_ids.c   | 22 ++++++++++++----------
>  drivers/mtd/ubispl/ubispl.c       |  2 +-
>  include/linux/mtd/rawnand.h       | 23 +++++++++++++----------
>  lib/tiny-printf.c                 |  2 +-
>  6 files changed, 35 insertions(+), 26 deletions(-)
> 
> -- 
> 2.45.2
>