[PATCH v1 1/1] x86: cpu: Describe board final hooks in the header

[PATCH v1 1/1] x86: cpu: Describe board final hooks in the header

[Andy Shevchenko]

The new two declarations board_final_init() and board_final_cleanup()
need a description. Add it here.

Suggested-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 arch/x86/include/asm/cpu.h | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/x86/include/asm/cpu.h b/arch/x86/include/asm/cpu.h
index d71bc1b80c05..a5b2043f7de1 100644
--- a/arch/x86/include/asm/cpu.h
+++ b/arch/x86/include/asm/cpu.h
@@ -298,7 +298,20 @@ u32 cpu_get_stepping(void);
  */
 int cpu_phys_address_size(void);
 
+/**
+ * board_final_init() - Final initialization hook (optional)
+ *
+ * Implements a custom initialization for boards that need to do it
+ * before the system is ready.
+ */
 void board_final_init(void);
+
+/**
+ * board_final_cleanup() - Final cleanup hook (optional)
+ *
+ * Implements a custom cleanup for boards that need to do it before
+ * booting the OS.
+ */
 void board_final_cleanup(void);
 
 #ifndef CONFIG_EFI_STUB
-- 
2.43.0.rc1.1336.g36b5255a03ac

Re: [PATCH v1 1/1] x86: cpu: Describe board final hooks in the header

[Simon Glass]

On Fri, 18 Oct 2024 at 09:56, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> The new two declarations board_final_init() and board_final_cleanup()
> need a description. Add it here.
>
> Suggested-by: Simon Glass <sjg@chromium.org>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  arch/x86/include/asm/cpu.h | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>

Reviewed-by: Simon Glass <sjg@chromium.org>


> diff --git a/arch/x86/include/asm/cpu.h b/arch/x86/include/asm/cpu.h
> index d71bc1b80c05..a5b2043f7de1 100644
> --- a/arch/x86/include/asm/cpu.h
> +++ b/arch/x86/include/asm/cpu.h
> @@ -298,7 +298,20 @@ u32 cpu_get_stepping(void);
>   */
>  int cpu_phys_address_size(void);
>
> +/**
> + * board_final_init() - Final initialization hook (optional)
> + *
> + * Implements a custom initialization for boards that need to do it
> + * before the system is ready.
> + */
>  void board_final_init(void);
> +
> +/**
> + * board_final_cleanup() - Final cleanup hook (optional)
> + *
> + * Implements a custom cleanup for boards that need to do it before
> + * booting the OS.
> + */
>  void board_final_cleanup(void);
>
>  #ifndef CONFIG_EFI_STUB
> --
> 2.43.0.rc1.1336.g36b5255a03ac
>

Re: [PATCH v1 1/1] x86: cpu: Describe board final hooks in the header

[Andy Shevchenko]

On Sat, Oct 19, 2024 at 05:51:00AM -0600, Simon Glass wrote:
> On Fri, 18 Oct 2024 at 09:56, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > The new two declarations board_final_init() and board_final_cleanup()
> > need a description. Add it here.
> >
> > Suggested-by: Simon Glass <sjg@chromium.org>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >  arch/x86/include/asm/cpu.h | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> >
> 
> Reviewed-by: Simon Glass <sjg@chromium.org>

What's the status of this?

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 1/1] x86: cpu: Describe board final hooks in the header

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 825 bytes --]

On Fri, May 09, 2025 at 03:53:03PM +0300, Andy Shevchenko wrote:
> On Sat, Oct 19, 2024 at 05:51:00AM -0600, Simon Glass wrote:
> > On Fri, 18 Oct 2024 at 09:56, Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > >
> > > The new two declarations board_final_init() and board_final_cleanup()
> > > need a description. Add it here.
> > >
> > > Suggested-by: Simon Glass <sjg@chromium.org>
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > ---
> > >  arch/x86/include/asm/cpu.h | 13 +++++++++++++
> > >  1 file changed, 13 insertions(+)
> > >
> > 
> > Reviewed-by: Simon Glass <sjg@chromium.org>
> 
> What's the status of this?

I haven't heard from Bin in a while, so I guess I should go and pickup
the outstanding patches. Thanks for the reminder.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

Re: [PATCH v1 1/1] x86: cpu: Describe board final hooks in the header

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 395 bytes --]

On Fri, Oct 18, 2024 at 06:55:57PM +0300, Andy Shevchenko wrote:

> The new two declarations board_final_init() and board_final_cleanup()
> need a description. Add it here.
> 
> Suggested-by: Simon Glass <sjg@chromium.org>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]