Re: [PATCH 1/3] gpio: at91: Implement GPIOF_FUNC in get_function()

Eugen Hristev
2024-11-12T15:59:09Z

On 11/12/24 17:57, Zixun LI wrote:
> Hello,
>
>
> On Tue, Nov 12, 2024 at 2:13 PM Eugen Hristev <eugen.hristev@linaro.org> wrote:
>>
>>
>>> +static bool at91_get_port_pio(struct at91_port *at91_port, int offset)
>>
>> The name get_port_pio is a bit confusing, can you rename it to something
>> more meaningful, like maybe is_periph_func or something ?
>
> How about at91_is_port_pio_active, more inline to the datasheet.

I am not sure. It appears confusing to me.
The pin is either in GPIO or peripheral function mode.
Being 'PIO active' appears to be something different, or common to both
options.
What does the datasheet say exactly ?