public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Rasmus Villemoes <ravi@prevas.dk>
To: u-boot@lists.denx.de
Cc: Marek Vasut <marex@denx.de>, Tim Harvey <tharvey@gateworks.com>,
	Heiko Schocher <hs@denx.de>, Tom Rini <trini@konsulko.com>,
	Rasmus Villemoes <ravi@prevas.dk>
Subject: [PATCH] imx8m: set sane default value for SPL_LOAD_FIT_ADDRESS
Date: Thu, 24 Oct 2024 12:01:45 +0200	[thread overview]
Message-ID: <20241024100145.841964-1-ravi@prevas.dk> (raw)

I enabled IMX_HAB on an imx8mp board, but even though I knew about the
implementation, I forgot that I had to provide a sane value for
SPL_LOAD_FIT_ADDRESS. The help text for IMX_HAB doesn't mention this
implicit requirement, and there's no build-time warning; the default
0x0 value just ends up being returned from
board_spl_fit_buffer_addr(), obviously resulting in a non-booting
board.

The existing imx8m* board configs that set a non-zero value currently
all use 0x44000000. The actual value doesn't matter too much, but 0 is
always wrong for imx8m platforms. So just use 0x44000000 as default
for those platforms.

Signed-off-by: Rasmus Villemoes <ravi@prevas.dk>
---
 boot/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/boot/Kconfig b/boot/Kconfig
index 940389d4882..72d1f69afcd 100644
--- a/boot/Kconfig
+++ b/boot/Kconfig
@@ -231,6 +231,7 @@ config SPL_LOAD_FIT
 config SPL_LOAD_FIT_ADDRESS
 	hex "load address of fit image"
 	depends on SPL_LOAD_FIT
+	default 0x44000000 if ARCH_IMX8M
 	default 0x0
 	help
 	  Specify the load address of the fit image that will be loaded
-- 
2.47.0


             reply	other threads:[~2024-10-24 10:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-24 10:01 Rasmus Villemoes [this message]
2024-10-24 11:51 ` [PATCH] imx8m: set sane default value for SPL_LOAD_FIT_ADDRESS Marek Vasut
2024-10-24 13:18   ` Rasmus Villemoes
2024-10-24 14:06     ` Marek Vasut
2024-10-24 15:20       ` Tom Rini
2024-10-24 16:13         ` Marek Vasut
2024-10-25  8:41           ` Rasmus Villemoes
2024-10-25 23:02             ` Marek Vasut
2024-10-26  0:24   ` Fabio Estevam
2024-10-26  0:32     ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241024100145.841964-1-ravi@prevas.dk \
    --to=ravi@prevas.dk \
    --cc=hs@denx.de \
    --cc=marex@denx.de \
    --cc=tharvey@gateworks.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox