Re: [PATCH] imx8m: set sane default value for SPL_LOAD_FIT_ADDRESS

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1081 bytes --]

On Fri, Oct 25, 2024 at 09:24:10PM -0300, Fabio Estevam wrote:
> On Thu, Oct 24, 2024 at 8:51 AM Marek Vasut <marex@denx.de> wrote:
> >
> > On 10/24/24 12:01 PM, Rasmus Villemoes wrote:
> > > I enabled IMX_HAB on an imx8mp board, but even though I knew about the
> > > implementation, I forgot that I had to provide a sane value for
> > > SPL_LOAD_FIT_ADDRESS. The help text for IMX_HAB doesn't mention this
> > > implicit requirement, and there's no build-time warning; the default
> > > 0x0 value just ends up being returned from
> > > board_spl_fit_buffer_addr(), obviously resulting in a non-booting
> > > board.
> > >
> > > The existing imx8m* board configs that set a non-zero value currently
> > > all use 0x44000000. The actual value doesn't matter too much, but 0 is
> > > always wrong for imx8m platforms. So just use 0x44000000 as default
> > > for those platforms.
> > >
> > > Signed-off-by: Rasmus Villemoes <ravi@prevas.dk>
> 
> Applied, thanks.

In that moving to a different default is a tangential cleanup, I'm fine
with this.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]