* [PATCH] riscv64: dts: starfive: Mars ethernet0 phy delay values sync with upstream Linux
@ 2024-10-26 12:40 E Shattow
2024-10-28 7:59 ` Leo Liang
0 siblings, 1 reply; 2+ messages in thread
From: E Shattow @ 2024-10-26 12:40 UTC (permalink / raw)
To: u-boot
Cc: E Shattow, Minda Chen, Tom Rini, Leo Yu-Chi Liang,
Heinrich Schuchardt, Lukas Funke, Aurelien Jarno, H Bell,
Chanho Park
Milk-V Mars vendor board support package has value 0xa (multiplier=150) for both
rx and tx delay. Upstream Linux has this as 1500 for both rx and tx delay. There
is no documentation for why this should remain 1900 so correct it now. Mars CM
and Mars CM Lite follow the same network phy delay values as Mars in the vendor
board support package.
Fixes: 92db23f7660de5897c8e3b91489b5b5780ffcd16
Signed-off-by: E Shattow <e@freeshell.de>
---
board/starfive/visionfive2/spl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/starfive/visionfive2/spl.c b/board/starfive/visionfive2/spl.c
index 54c23ed2e1..f63f36c7f7 100644
--- a/board/starfive/visionfive2/spl.c
+++ b/board/starfive/visionfive2/spl.c
@@ -41,7 +41,7 @@ static const struct starfive_vf2_pro milk_v_mars[] = {
{"/soc/ethernet@16030000/mdio/ethernet-phy@0",
"motorcomm,rx-data-drv-microamp", "2910"},
{"/soc/ethernet@16030000/mdio/ethernet-phy@0",
- "rx-internal-delay-ps", "1900"},
+ "rx-internal-delay-ps", "1500"},
{"/soc/ethernet@16030000/mdio/ethernet-phy@0",
"tx-internal-delay-ps", "1500"},
};
--
2.45.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] riscv64: dts: starfive: Mars ethernet0 phy delay values sync with upstream Linux
2024-10-26 12:40 [PATCH] riscv64: dts: starfive: Mars ethernet0 phy delay values sync with upstream Linux E Shattow
@ 2024-10-28 7:59 ` Leo Liang
0 siblings, 0 replies; 2+ messages in thread
From: Leo Liang @ 2024-10-28 7:59 UTC (permalink / raw)
To: E Shattow
Cc: u-boot, Minda Chen, Tom Rini, Heinrich Schuchardt, Lukas Funke,
Aurelien Jarno, H Bell, Chanho Park
On Sat, Oct 26, 2024 at 05:40:15AM -0700, E Shattow wrote:
> Milk-V Mars vendor board support package has value 0xa (multiplier=150) for both
> rx and tx delay. Upstream Linux has this as 1500 for both rx and tx delay. There
> is no documentation for why this should remain 1900 so correct it now. Mars CM
> and Mars CM Lite follow the same network phy delay values as Mars in the vendor
> board support package.
>
> Fixes: 92db23f7660de5897c8e3b91489b5b5780ffcd16
> Signed-off-by: E Shattow <e@freeshell.de>
> ---
> board/starfive/visionfive2/spl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-28 8:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-26 12:40 [PATCH] riscv64: dts: starfive: Mars ethernet0 phy delay values sync with upstream Linux E Shattow
2024-10-28 7:59 ` Leo Liang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox