From: david regan <dregan@broadcom.com>
To: u-boot@lists.denx.de,
Dario Binacchi <dario.binacchi@amarulasolutions.com>,
Michael Trimarchi <michael@amarulasolutions.com>,
Anand Gore <anand.gore@broadcom.com>,
William Zhang <william.zhang@broadcom.com>,
Kursad Oney <kursad.oney@broadcom.com>,
Philippe Reynes <philippe.reynes@softathome.com>,
Linus Walleij <linus.walleij@linaro.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Kamal Dasu <kamal.dasu@broadcom.com>,
Tom Rini <trini@konsulko.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
dregan@mail.com, dregan@broadcom.com
Subject: [PATCH v2 4/4] mtd: rawnand: brcmnand: update log level messages
Date: Tue, 12 Nov 2024 22:27:15 -0800 [thread overview]
Message-ID: <20241113062715.2872-5-dregan@broadcom.com> (raw)
In-Reply-To: <20241113062715.2872-1-dregan@broadcom.com>
Update log level messages so that more critical messages can be logged
to console and help the troubleshooting with field devices.
This is a port of the upstream Linux patch to U-Boot.
https://lore.kernel.org/linux-mtd/20240223034758.13753-4-william.zhang@broadcom.com/
Signed-off-by: david regan <dregan@broadcom.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: William Zhang <william.zhang@broadcom.com>
Reviewed-by: Anand Gore <anand.gore@broadcom.com>
---
drivers/mtd/nand/raw/brcmnand/brcmnand.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
index 7fd9e1855d1e..ef492e6db320 100644
--- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
+++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
@@ -1071,8 +1071,8 @@ static int bcmnand_ctrl_poll_status(struct brcmnand_controller *ctrl,
if ((val & mask) == expected_val)
return 0;
- dev_warn(ctrl->dev, "timeout on status poll (expected %x got %x)\n",
- expected_val, val & mask);
+ dev_err(ctrl->dev, "timeout on status poll (expected %x got %x)\n",
+ expected_val, val & mask);
return -ETIMEDOUT;
}
@@ -2032,7 +2032,7 @@ try_dmaread:
return err;
}
- dev_dbg(ctrl->dev, "uncorrectable error at 0x%llx\n",
+ dev_err(ctrl->dev, "uncorrectable error at 0x%llx\n",
(unsigned long long)err_addr);
mtd->ecc_stats.failed++;
/* NAND layer expects zero on ECC errors */
--
2.37.3
next prev parent reply other threads:[~2024-11-13 13:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 6:27 [PATCH v2 0/4] Broadcom BCMBCA nand updates david regan
2024-11-13 6:27 ` [PATCH v2 1/4] mtd: nand: brcmnand: remove device specific nand driver files david regan
2024-11-13 6:27 ` [PATCH v2 2/4] arm: dts: Use upstream dts david regan
2024-11-13 6:27 ` [PATCH v2 3/4] mtd: rawnand: brcmnand: Default bcmbca parameter_page_big_endian to zero david regan
2024-11-13 7:53 ` Linus Walleij
2024-11-13 6:27 ` david regan [this message]
2024-11-13 8:26 ` [PATCH v2 0/4] Broadcom BCMBCA nand updates Michael Nazzareno Trimarchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241113062715.2872-5-dregan@broadcom.com \
--to=dregan@broadcom.com \
--cc=anand.gore@broadcom.com \
--cc=dario.binacchi@amarulasolutions.com \
--cc=dregan@mail.com \
--cc=florian.fainelli@broadcom.com \
--cc=jiaxun.yang@flygoat.com \
--cc=kamal.dasu@broadcom.com \
--cc=kursad.oney@broadcom.com \
--cc=linus.walleij@linaro.org \
--cc=michael@amarulasolutions.com \
--cc=miquel.raynal@bootlin.com \
--cc=philippe.reynes@softathome.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=william.zhang@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox