Re: [PATCH v2] cmd: add a fetch utility

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 3250 bytes --]

On Wed, Nov 13, 2024 at 03:40:01PM +0100, Heinrich Schuchardt wrote:
> Am 13. November 2024 14:32:57 MEZ schrieb Neil Armstrong <neil.armstrong@linaro.org>:
> >On 13/11/2024 05:22, Caleb Connolly wrote:
> >> Add a small utility for displaying some information about U-Boot and the
> >> hardware it's running on in a similar fashion to the popular neofetch
> >> tool for Linux [1].
> >> 
> >> While the output is meant to be useful, it should also be pleasing to
> >> look at and perhaps entertaining. The ufetch command aims to bring this
> >> to U-Boot, featuring a colorful ASCII art version of the U-Boot logo.
> >> 
> >> [1]: https://en.wikipedia.org/wiki/Neofetch
> >> 
> >> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
> >> ---
> >> Ephemeral screenshot: https://0x0.st/XkQU.png
> >> 
> >> Changes since v1:
> >>   * Rework storage info to be more dynamic
> >>   * use print_size() helper everywhere
> >>   * manually walk RAM banks to report memory size correctly
> >>   * minor formatting changes and fixes
> >>   * MAINTAINERS entry
> >>   * V1: https://lore.kernel.org/u-boot/20240808163153.2069650-1-caleb.connolly@linaro.org
> >> ---
> >>   MAINTAINERS  |   5 ++
> >>   cmd/Kconfig  |   7 ++
> >>   cmd/Makefile |   1 +
> >>   cmd/ufetch.c | 224 +++++++++++++++++++++++++++++++++++++++++++++++++++
> >>   4 files changed, 237 insertions(+)
> >>   create mode 100644 cmd/ufetch.c
> >> 
> >> diff --git a/MAINTAINERS b/MAINTAINERS
> >> index 38c714cf46a6..d1eb164ad590 100644
> >> --- a/MAINTAINERS
> >> +++ b/MAINTAINERS
> >> @@ -1724,8 +1724,13 @@ M:	Heiko Schocher <hs@denx.de>
> >>   S:	Maintained
> >>   T:	git https://source.denx.de/u-boot/custodians/u-boot-ubi.git
> >>   F:	drivers/mtd/ubi/
> >>   +UFETCH
> >> +M:	Caleb Connolly <caleb.connolly@linaro.org>
> >> +S:	Maintained
> >> +F:	cmd/ufetch.c
> >> +
> >>   UFS
> >>   M:	Neil Armstrong <neil.armstrong@linaro.org>
> >>   M:	Bhupesh Sharma <bhupesh.linux@gmail.com>
> >>   M:	Neha Malcom Francis <n-francis@ti.com>
> >> diff --git a/cmd/Kconfig b/cmd/Kconfig
> >> index 4fba9fe67034..da736249a3cf 100644
> >> --- a/cmd/Kconfig
> >> +++ b/cmd/Kconfig
> >> @@ -175,8 +175,15 @@ config CMD_CPU
> >>   	  number of CPUs, type (e.g. manufacturer, architecture, product or
> >>   	  internal name) and clock frequency. Other information may be
> >>   	  available depending on the CPU driver.
> >>   +config CMD_UFETCH
> >> +	bool "U-Boot fetch"
> >> +	depends on BLK
> >> +	help
> >> +	  Fetch utility for U-Boot (akin to neofetch). Prints information
> >> +	  about U-Boot and the board it is running on in a pleasing format.
> 
> The information is already available in other commands with greater detail.
> 
> What is your use case?

The use case was outlined in v1 and maybe missed in v2. This is a "toy"
utility, like 2048, to make it easier to show off things like "I just
made U-Boot work on this new platform". So yes, it's going to bloat the
code size, but it's also not going to be enabled in production (or
hopefully, defconfigs when submitted for new boards...).

[snip]
> >
> >Ephemeral screenshot: https://0x0.st/Xk2N.png

The point is to do something like that.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]