From: Tom Rini <trini@konsulko.com>
To: Nam Cao <namcao@linutronix.de>
Cc: Simon Glass <sjg@chromium.org>,
Mattijs Korpershoek <mkorpershoek@baylibre.com>,
Ion Agorria <ion@agorria.com>,
Svyatoslav Ryhel <clamor95@gmail.com>,
Mayuresh Chitale <mchitale@ventanamicro.com>,
Sean Anderson <seanga2@gmail.com>,
AKASHI Takahiro <akashi.tkhro@gmail.com>,
Javier Fernandez Pastrana <javier.pastrana@linutronix.de>,
u-boot@lists.denx.de
Subject: Re: [PATCH v2 1/2] boot: extlinux: Fix unaligned buffer for reading data from file system
Date: Mon, 18 Nov 2024 13:30:08 -0600 [thread overview]
Message-ID: <20241118193008.GS3600562@bill-the-cat> (raw)
In-Reply-To: <1eb402380414c2b8f1b25d0c63d894efefce4ab9.1730988601.git.namcao@linutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1047 bytes --]
On Thu, Nov 07, 2024 at 04:01:05PM +0100, Nam Cao wrote:
> extlinux_read_bootflow() allocates a buffer to read from file system
> without any alignment.
>
> But for some block devices which transfer data via DMA, ARCH_DMA_MINALIGN
> alignment is required. For example, due to misaligned buffer, the below
> boot failure is observed.
>
> => boot
> CACHE: Misaligned operation at range [9efa25f8, 9efa27f8]
> CACHE: Misaligned operation at range [9efa25f8, 9efa27f8]
> CACHE: Misaligned operation at range [9efa25f8, 9efa27f8]
> CACHE: Misaligned operation at range [9efa25f8, 9efa27f8]
> ** Booting bootflow 'mmc@2194000.bootdev.part_1' with extlinux
> Ignoring unknown command: �D���D��
> Boot failed (err=-14)
>
> Change the buffer alignment to ARCH_DMA_MINALIGN.
>
> Fixes: 31aefaf89a5b ("bootstd: Add an implementation of distro boot")
> Signed-off-by: Nam Cao <namcao@linutronix.de>
> Tested-by: Javier Fernandez Pastrana <javier.pastrana@linutronix.de>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2024-11-18 19:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 15:01 [PATCH v2 0/2] Fix boot failure due to misaligned DMA buffer Nam Cao
2024-11-07 15:01 ` [PATCH v2 1/2] boot: extlinux: Fix unaligned buffer for reading data from file system Nam Cao
2024-11-18 19:30 ` Tom Rini [this message]
2024-11-07 15:01 ` [PATCH v2 2/2] fs: Use ARCH_DMA_MINALIGN as default alignment for fs_read_alloc() Nam Cao
2024-11-18 19:30 ` Tom Rini
2024-11-08 1:27 ` [PATCH v2 0/2] Fix boot failure due to misaligned DMA buffer Tony Dinh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241118193008.GS3600562@bill-the-cat \
--to=trini@konsulko.com \
--cc=akashi.tkhro@gmail.com \
--cc=clamor95@gmail.com \
--cc=ion@agorria.com \
--cc=javier.pastrana@linutronix.de \
--cc=mchitale@ventanamicro.com \
--cc=mkorpershoek@baylibre.com \
--cc=namcao@linutronix.de \
--cc=seanga2@gmail.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox