From: Adriano Cordova <adrianox@gmail.com>
To: u-boot@lists.denx.de
Cc: joe.hershberger@ni.com, rfried.dev@gmail.com,
jerome.forissier@linaro.org, xypron.glpk@gmx.de,
ilias.apalodimas@linaro.org, Adriano Cordova <adrianox@gmail.com>
Subject: [PATCH v5 07/14] efi_loader: device_path: add support for HTTP device path
Date: Sun, 24 Nov 2024 21:58:07 -0300 [thread overview]
Message-ID: <20241125005814.236669-8-adrianox@gmail.com> (raw)
In-Reply-To: <20241125005814.236669-1-adrianox@gmail.com>
Add efi_dp_from_http to form a device path from HTTP. The
device path is the concatenation of the device path returned
by efi_dp_from_ipv4 together with an URI node and an END node.
Signed-off-by: Adriano Cordova <adrianox@gmail.com>
---
Changes in v5:
- Add function description to efi_dp_from_http
- Check if dp1 is NULL in efi_dp_from_http
- Use strcat
Changes in v4:
- Reworked an if-else
Changes in v3:
- Moved argument checks in efi_dp_from_http to the beginning of the function
include/efi_loader.h | 1 +
lib/efi_loader/efi_device_path.c | 63 ++++++++++++++++++++++++++++++++
2 files changed, 64 insertions(+)
diff --git a/include/efi_loader.h b/include/efi_loader.h
index 612bc42816..96b204dfc3 100644
--- a/include/efi_loader.h
+++ b/include/efi_loader.h
@@ -872,6 +872,7 @@ struct efi_device_path *efi_dp_part_node(struct blk_desc *desc, int part);
struct efi_device_path *efi_dp_from_file(const struct efi_device_path *dp,
const char *path);
struct efi_device_path *efi_dp_from_eth(void);
+struct efi_device_path *efi_dp_from_http(const char *server);
struct efi_device_path *efi_dp_from_mem(uint32_t mem_type,
uint64_t start_address,
size_t size);
diff --git a/lib/efi_loader/efi_device_path.c b/lib/efi_loader/efi_device_path.c
index 96e72f72fc..1e512bf0ea 100644
--- a/lib/efi_loader/efi_device_path.c
+++ b/lib/efi_loader/efi_device_path.c
@@ -1017,6 +1017,69 @@ static struct efi_device_path *efi_dp_from_ipv4(struct efi_ipv4_address *ip,
return dp2;
}
+/**
+ * efi_dp_from_http() - set device path from http
+ *
+ * Set the device path to an IPv4 path as provided by efi_dp_from_ipv4
+ * concatenated with a device path of subtype DEVICE_PATH_SUB_TYPE_MSG_URI,
+ * and an END node.
+ *
+ * @server: URI of remote server
+ */
+struct efi_device_path *efi_dp_from_http(const char *server)
+{
+ struct efi_device_path *dp1, *dp2;
+ struct efi_device_path_uri *uridp;
+ efi_uintn_t uridp_len;
+ char *pos;
+ char tmp[128];
+ struct efi_ipv4_address ip;
+ struct efi_ipv4_address mask;
+
+ if ((server && strlen("http://") + strlen(server) + 1 > sizeof(tmp)) ||
+ (!server && IS_ENABLED(CONFIG_NET_LWIP)))
+ return NULL;
+
+ efi_net_get_addr(&ip, &mask, NULL);
+
+ dp1 = efi_dp_from_ipv4(&ip, &mask, NULL);
+ if (!dp1)
+ return NULL;
+
+ strcpy(tmp, "http://");
+
+ if (server) {
+ strlcat(tmp, server, sizeof(tmp));
+ }
+#if !IS_ENABLED(CONFIG_NET_LWIP)
+ else {
+ ip_to_string(net_server_ip, tmp + strlen("http://"));
+ }
+#endif
+
+ uridp_len = sizeof(struct efi_device_path) + strlen(tmp) + 1;
+ uridp = efi_alloc(uridp_len + sizeof(END));
+ if (!uridp) {
+ log_err("Out of memory\n");
+ return NULL;
+ }
+ uridp->dp.type = DEVICE_PATH_TYPE_MESSAGING_DEVICE;
+ uridp->dp.sub_type = DEVICE_PATH_SUB_TYPE_MSG_URI;
+ uridp->dp.length = uridp_len;
+ debug("device path: setting uri device path to %s\n", tmp);
+ memcpy(uridp->uri, tmp, strlen(tmp) + 1);
+
+ pos = (char *)uridp + uridp_len;
+ memcpy(pos, &END, sizeof(END));
+
+ dp2 = efi_dp_concat(dp1, (const struct efi_device_path *)uridp, 0);
+
+ efi_free_pool(uridp);
+ efi_free_pool(dp1);
+
+ return dp2;
+}
+
/* Construct a device-path for memory-mapped image */
struct efi_device_path *efi_dp_from_mem(uint32_t memory_type,
uint64_t start_address,
--
2.43.0
next prev parent reply other threads:[~2024-11-25 0:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 0:58 [PATCH v5 00/14] efi_loader: efi http and ipconfig drivers Adriano Cordova
2024-11-25 0:58 ` [PATCH v5 01/14] net: wget: let wget_with_dns work with dns disabled Adriano Cordova
2024-11-25 8:32 ` Heinrich Schuchardt
2024-11-25 8:56 ` Jerome Forissier
2024-11-25 0:58 ` [PATCH v5 02/14] efi_loader: device_path: add definition of DEVICE_PATH_SUB_TYPE_MSG_IPV4 Adriano Cordova
2024-11-25 0:58 ` [PATCH v5 03/14] efi_loader: device_path: add efi_dp_from_ipv4 Adriano Cordova
2024-11-25 8:42 ` Heinrich Schuchardt
2024-11-25 14:06 ` Adriano Córdova
2024-11-25 0:58 ` [PATCH v5 04/14] efi_loader: add IPv4() to device path to text protocol Adriano Cordova
2024-11-25 0:58 ` [PATCH v5 05/14] efi_api: add definitions for HTTP and IP4_CONFIG2 protocols Adriano Cordova
2024-11-25 0:58 ` [PATCH v5 06/14] efi_loader: efi_net: add efi_net_set_addr, efi_net_get_addr Adriano Cordova
2024-11-25 0:58 ` Adriano Cordova [this message]
2024-11-25 15:00 ` [PATCH v5 07/14] efi_loader: device_path: add support for HTTP device path Heinrich Schuchardt
2024-11-25 0:58 ` [PATCH v5 08/14] efi_loader: net: set EFI bootdevice device path to HTTP when loaded from wget Adriano Cordova
2024-11-25 15:40 ` Heinrich Schuchardt
2024-11-27 2:19 ` Adriano Córdova
2024-11-25 0:58 ` [PATCH v5 09/14] efi_loader: net: add support to send http requests and parse http headers Adriano Cordova
2024-11-25 0:58 ` [PATCH v5 10/14] efi_loader: efi_net: add EFI_IP4_CONFIG2_PROTOCOL Adriano Cordova
2024-11-25 0:58 ` [PATCH v5 11/14] efi_loader: efi_net: add EFI_HTTP_PROTOCOL Adriano Cordova
2024-11-25 0:58 ` [PATCH v5 12/14] lib: uuid: display HTTP and IPV4 Config II protocols Adriano Cordova
2024-11-25 0:58 ` [PATCH v5 13/14] efi_selftest: add test for HTTP protocol Adriano Cordova
2024-11-25 0:58 ` [PATCH v5 14/14] efi_selftest: add test for IPv4 Config2 protocol Adriano Cordova
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241125005814.236669-8-adrianox@gmail.com \
--to=adrianox@gmail.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jerome.forissier@linaro.org \
--cc=joe.hershberger@ni.com \
--cc=rfried.dev@gmail.com \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox