U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Adriano Cordova <adrianox@gmail.com>
To: u-boot@lists.denx.de
Cc: joe.hershberger@ni.com, rfried.dev@gmail.com,
	jerome.forissier@linaro.org, xypron.glpk@gmx.de,
	ilias.apalodimas@linaro.org, Adriano Cordova <adrianox@gmail.com>
Subject: [PATCH v6 03/14] efi_loader: device_path: add efi_dp_from_ipv4
Date: Thu, 28 Nov 2024 11:44:05 -0300	[thread overview]
Message-ID: <20241128144416.604126-4-adrianox@gmail.com> (raw)
In-Reply-To: <20241128144416.604126-1-adrianox@gmail.com>

Add efi_dp_from_ipv4 to form a device path from an ipv4 address.

Signed-off-by: Adriano Cordova <adrianox@gmail.com>
---
Changes in v6:
- Complete documentation of efi_dp_from_ipv4
- Return NULL in efi_dp_from_ipv4 if allocation fails

Changes in v5:
- Add function description to efi_dp_from_ipv4
- Allocate ipv4dp in the stack
- Make efi_dp_from_ipv4 static
- Remove u-boot log messages inside efi routine
- Change (void *)(uintptr_t) to char *

Changes in v4:
- Fix memcpy mistake

Changes in v3:
- Remove some unnecessary void* casts.
- Change sizeof(struct efi_device_path_ipv4) to sizeof(*ipv4dp)
  in efi_dp_from_ipv4.
 lib/efi_loader/efi_device_path.c | 47 ++++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)

diff --git a/lib/efi_loader/efi_device_path.c b/lib/efi_loader/efi_device_path.c
index ee387e1dfd..6fcbc91e0b 100644
--- a/lib/efi_loader/efi_device_path.c
+++ b/lib/efi_loader/efi_device_path.c
@@ -974,6 +974,53 @@ struct efi_device_path __maybe_unused *efi_dp_from_eth(void)
 	return start;
 }
 
+/**
+ * efi_dp_from_ipv4() - set device path from IPv4 address
+ *
+ * Set the device path to an ethernet device path as provided by
+ * efi_dp_from_eth() concatenated with a device path of subtype
+ * DEVICE_PATH_SUB_TYPE_MSG_IPV4, and an END node.
+ *
+ * @ip:		IPv4 local address
+ * @mask:	network mask
+ * @srv:	IPv4 remote/server address
+ * Return:	pointer to device path, NULL on error
+ */
+static struct efi_device_path *efi_dp_from_ipv4(struct efi_ipv4_address *ip,
+					 struct efi_ipv4_address *mask,
+					 struct efi_ipv4_address *srv)
+{
+	struct efi_device_path *dp1, *dp2, *pos;
+	struct {
+		struct efi_device_path_ipv4 ipv4dp;
+		struct efi_device_path end;
+	} dp;
+
+	memset(&dp.ipv4dp, 0, sizeof(dp.ipv4dp));
+	dp.ipv4dp.dp.type = DEVICE_PATH_TYPE_MESSAGING_DEVICE;
+	dp.ipv4dp.dp.sub_type = DEVICE_PATH_SUB_TYPE_MSG_IPV4;
+	dp.ipv4dp.dp.length = sizeof(dp.ipv4dp);
+	dp.ipv4dp.protocol = 6;
+	if (ip)
+		memcpy(&dp.ipv4dp.local_ip_address, ip, sizeof(*ip));
+	if (mask)
+		memcpy(&dp.ipv4dp.subnet_mask, mask, sizeof(*mask));
+	if (srv)
+		memcpy(&dp.ipv4dp.remote_ip_address, srv, sizeof(*srv));
+	pos = &dp.end;
+	memcpy(pos, &END, sizeof(END));
+
+	dp1 = efi_dp_from_eth();
+	if (!dp1)
+		return NULL;
+
+	dp2 = efi_dp_concat(dp1, (const struct efi_device_path *)&dp, 0);
+
+	efi_free_pool(dp1);
+
+	return dp2;
+}
+
 /* Construct a device-path for memory-mapped image */
 struct efi_device_path *efi_dp_from_mem(uint32_t memory_type,
 					uint64_t start_address,
-- 
2.43.0


  parent reply	other threads:[~2024-11-28 14:44 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-28 14:44 [PATCH v6 00/14] efi_loader: efi http and ipconfig drivers Adriano Cordova
2024-11-28 14:44 ` [PATCH v6 01/14] net: wget: let wget_with_dns work with dns disabled Adriano Cordova
2024-11-28 14:44 ` [PATCH v6 02/14] efi_loader: device_path: add definition of DEVICE_PATH_SUB_TYPE_MSG_IPV4 Adriano Cordova
2024-11-28 14:44 ` Adriano Cordova [this message]
2024-12-03 13:12   ` [PATCH v6 03/14] efi_loader: device_path: add efi_dp_from_ipv4 Ilias Apalodimas
2024-11-28 14:44 ` [PATCH v6 04/14] efi_loader: add IPv4() to device path to text protocol Adriano Cordova
2024-11-28 14:44 ` [PATCH v6 05/14] efi_api: add definitions for HTTP and IP4_CONFIG2 protocols Adriano Cordova
2024-12-03 13:13   ` Ilias Apalodimas
2024-11-28 14:44 ` [PATCH v6 06/14] efi_loader: efi_net: add efi_net_set_addr, efi_net_get_addr Adriano Cordova
2024-12-03 10:51   ` Heinrich Schuchardt
2024-12-03 13:52     ` Jerome Forissier
2024-11-28 14:44 ` [PATCH v6 07/14] efi_loader: device_path: add support for HTTP device path Adriano Cordova
2024-12-03 13:16   ` Ilias Apalodimas
2024-11-28 14:44 ` [PATCH v6 08/14] efi_loader: net: set EFI bootdevice device path to HTTP when loaded from wget Adriano Cordova
2024-12-03 11:46   ` Heinrich Schuchardt
2024-11-28 14:44 ` [PATCH v6 09/14] efi_loader: net: add support to send http requests and parse http headers Adriano Cordova
2024-12-03 11:48   ` Heinrich Schuchardt
2024-11-28 14:44 ` [PATCH v6 10/14] efi_loader: efi_net: add EFI_IP4_CONFIG2_PROTOCOL Adriano Cordova
2024-12-03 14:04   ` Ilias Apalodimas
2024-12-03 19:47     ` Adriano Córdova
2024-11-28 14:44 ` [PATCH v6 11/14] efi_loader: efi_net: add EFI_HTTP_PROTOCOL Adriano Cordova
2024-11-28 14:44 ` [PATCH v6 12/14] lib: uuid: display HTTP and IPV4 Config II protocols Adriano Cordova
2024-11-28 14:44 ` [PATCH v6 13/14] efi_selftest: add test for HTTP protocol Adriano Cordova
2024-12-03 13:11   ` Ilias Apalodimas
2024-12-03 19:36     ` Adriano Córdova
2024-11-28 14:44 ` [PATCH v6 14/14] efi_selftest: add test for IPv4 Config2 protocol Adriano Cordova
2024-12-03 13:02   ` Ilias Apalodimas
2024-12-03 19:43     ` Adriano Córdova

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241128144416.604126-4-adrianox@gmail.com \
    --to=adrianox@gmail.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=jerome.forissier@linaro.org \
    --cc=joe.hershberger@ni.com \
    --cc=rfried.dev@gmail.com \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox