From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9DBBCE7716E for ; Thu, 5 Dec 2024 23:38:33 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CB3BD89584; Fri, 6 Dec 2024 00:38:22 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="mbcXZPAG"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id EE8138907B; Thu, 5 Dec 2024 19:35:38 +0100 (CET) Received: from nyc.source.kernel.org (nyc.source.kernel.org [IPv6:2604:1380:45d1:ec00::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EB49789330 for ; Thu, 5 Dec 2024 19:35:36 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=devnull+j.ne.posteo.net@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id EF05AA40449; Thu, 5 Dec 2024 18:33:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 9EB4DC4CEDD; Thu, 5 Dec 2024 18:35:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1733423735; bh=JdPGuTCErkurBFo5LB4SxnjSgk8nN9NPZA5OZUGIocw=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=mbcXZPAGsUDRQrQvQq8fDeTQGKmivWptkj/1bCVZIrIjilgmMkX7EwScpJM00EQjM 0oQJmxCpoyi8P/wscPsCFV/CjyG53KSz8gM8AYbAcD56R+WFlkJB5RYMvCQllZpfPY +BrNmEELwmBqjtgkawIfaRQMjruCCLrQ3Eam/X1k9ophz4zjo1J9QnzWgJPkHPVgTN 5/q8j5itoIceTKtyQeLNcOGOP7LOL/28ev60H1/jw+3dxbrDLtyLVCobnHcn1WMFJL VYT2Qv3rIGLlf+ljPvcV6jEO/h83B3rmXcFhRZbXCAh6waNu7K6d+M1qB7c3rOYXr/ 6tWazOc0adEhw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B6ECE7716E; Thu, 5 Dec 2024 18:35:35 +0000 (UTC) From: =?utf-8?q?J=2E_Neusch=C3=A4fer_via_B4_Relay?= Date: Thu, 05 Dec 2024 19:35:33 +0100 Subject: [PATCH 1/3] cmd: ufetch: Fix type mismatch on 32-bit MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20241205-ufetch-v1-1-df861318bd49@posteo.net> References: <20241205-ufetch-v1-0-df861318bd49@posteo.net> In-Reply-To: <20241205-ufetch-v1-0-df861318bd49@posteo.net> To: Caleb Connolly , Tom Rini Cc: u-boot@lists.denx.de, =?utf-8?q?J=2E_Neusch=C3=A4fer?= X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1733423734; l=1379; i=j.ne@posteo.net; s=20240329; h=from:subject:message-id; bh=LwoC/gIfSd1zZvdtM9XMhWoFrjn1IKY1CizVqs40ZT8=; b=5gVIdB4NQ3Yaqso5eh0Qz4GRgbciAPOgs7b3yv+IG6Xunyimgpuj7jIQMeh6r9p8imbnTOYXb 5x8jsvdP+hcCXQY8HdyiuxNtBkjpMoxGnpd7bdPqwVdZkaRtpKw1J10 X-Developer-Key: i=j.ne@posteo.net; a=ed25519; pk=NIe0bK42wNaX/C4bi6ezm7NJK0IQE+8MKBm7igFMIS4= X-Endpoint-Received: by B4 Relay for j.ne@posteo.net/20240329 with auth_id=156 X-Original-From: =?utf-8?q?J=2E_Neusch=C3=A4fer?= X-Mailman-Approved-At: Fri, 06 Dec 2024 00:38:21 +0100 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: j.ne@posteo.net Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean From: "J. Neuschäfer" On 32-bit architectures, LAST_LINE (_LAST_LINE - 1UL) is 64 bits long, but size_t (from ARRAY_SIZE(...)) is 32 bits. This results in a warning because the max() macro expects the same type on both sides: cmd/ufetch.c: In function ‘do_ufetch’: include/linux/kernel.h:179:24: warning: comparison of distinct pointer types lacks a cast [-Wcompare-distinct-pointer-types] 179 | (void) (&_max1 == &_max2); \ | ^~ cmd/ufetch.c:92:25: note: in expansion of macro ‘max’ 92 | int num_lines = max(LAST_LINE + 1, ARRAY_SIZE(logo_lines)); | ^~~ Fix this by casting LAST_LINE to size_t. Signed-off-by: J. Neuschäfer --- cmd/ufetch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/ufetch.c b/cmd/ufetch.c index 0b825d7e8c75f3b18933d3e3f77e5f40f2c7b658..5f3ef847b268dc384271fc6774720e5fd2337157 100644 --- a/cmd/ufetch.c +++ b/cmd/ufetch.c @@ -89,7 +89,7 @@ enum output_lines { static int do_ufetch(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]) { - int num_lines = max(LAST_LINE + 1, ARRAY_SIZE(logo_lines)); + int num_lines = max((size_t)LAST_LINE + 1, ARRAY_SIZE(logo_lines)); const char *model, *compatible; char *ipaddr; int n_cmds, n_cpus = 0, ret, compatlen; -- 2.45.2