From: Tom Rini <trini@konsulko.com>
To: Adriano Cordova <adrianox@gmail.com>
Cc: u-boot@lists.denx.de, joe.hershberger@ni.com,
rfried.dev@gmail.com, jerome.forissier@linaro.org,
xypron.glpk@gmx.de, ilias.apalodimas@linaro.org
Subject: Re: [PATCH v7 08/14] efi_loader: net: set EFI bootdevice device path to HTTP when loaded from wget
Date: Wed, 4 Dec 2024 19:30:18 -0600 [thread overview]
Message-ID: <20241205013018.GA1377816@bill-the-cat> (raw)
In-Reply-To: <20241204030530.2099776-8-adrianox@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 838 bytes --]
On Wed, Dec 04, 2024 at 12:05:23AM -0300, Adriano Cordova wrote:
> Set the device path of the efi boot device to an HTTP device path
> (as formed by efi_dp_from_http) when the next boot stage is loaded
> using wget (i.e., when wget is used with wget_info.set_bootdev=1).
>
> When loaded from HTTP, the device path should account for it so that
> the next boot stage is aware (e.g. grub only loads its http stack if
> it itself was loaded from http, and it checks this from its device path).
>
> Signed-off-by: Adriano Cordova <adrianox@gmail.com>
> Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
I know this is applied now, but after re-checking some things in one of
my labs, this breaks test_efi_helloworld_builtin on rpi_3 at least (and
possibly others). There is no output from "bootefi hello".
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2024-12-05 1:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 3:05 [PATCH v7 01/14] net: wget: let wget_with_dns work with dns disabled Adriano Cordova
2024-12-04 3:05 ` [PATCH v7 02/14] efi_loader: device_path: add definition of DEVICE_PATH_SUB_TYPE_MSG_IPV4 Adriano Cordova
2024-12-04 3:05 ` [PATCH v7 03/14] efi_loader: device_path: add efi_dp_from_ipv4 Adriano Cordova
2024-12-04 3:05 ` [PATCH v7 04/14] efi_loader: add IPv4() to device path to text protocol Adriano Cordova
2024-12-04 3:05 ` [PATCH v7 05/14] efi_api: add definitions for HTTP and IP4_CONFIG2 protocols Adriano Cordova
2024-12-04 3:05 ` [PATCH v7 06/14] efi_loader: efi_net: add efi_net_set_addr, efi_net_get_addr Adriano Cordova
2024-12-04 3:05 ` [PATCH v7 07/14] efi_loader: device_path: add support for HTTP device path Adriano Cordova
2024-12-04 3:05 ` [PATCH v7 08/14] efi_loader: net: set EFI bootdevice device path to HTTP when loaded from wget Adriano Cordova
2024-12-05 1:30 ` Tom Rini [this message]
2024-12-05 9:00 ` Heinrich Schuchardt
2024-12-05 15:19 ` Tom Rini
2024-12-05 18:06 ` Heinrich Schuchardt
2024-12-05 21:30 ` Adriano Córdova
2024-12-04 3:05 ` [PATCH v7 09/14] efi_loader: net: add support to send http requests and parse http headers Adriano Cordova
2024-12-04 3:05 ` [PATCH v7 10/14] efi_loader: efi_net: add EFI_IP4_CONFIG2_PROTOCOL Adriano Cordova
2024-12-04 3:05 ` [PATCH v7 11/14] efi_loader: efi_net: add EFI_HTTP_PROTOCOL Adriano Cordova
2024-12-04 3:05 ` [PATCH v7 12/14] lib: uuid: display HTTP and IPV4 Config II protocols Adriano Cordova
2024-12-04 3:05 ` [PATCH v7 13/14] efi_selftest: add test for HTTP protocol Adriano Cordova
2024-12-04 3:05 ` [PATCH v7 14/14] efi_selftest: add test for IPv4 Config2 protocol Adriano Cordova
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241205013018.GA1377816@bill-the-cat \
--to=trini@konsulko.com \
--cc=adrianox@gmail.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jerome.forissier@linaro.org \
--cc=joe.hershberger@ni.com \
--cc=rfried.dev@gmail.com \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox