From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35FB9E7717F for ; Tue, 10 Dec 2024 05:47:09 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9142C8974E; Tue, 10 Dec 2024 06:47:07 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Mos4dXWn"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9A5A48974E; Tue, 10 Dec 2024 06:47:06 +0100 (CET) Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EDEEC8962C for ; Tue, 10 Dec 2024 06:46:58 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pericycle.cc@gmail.com Received: by mail-pl1-x642.google.com with SMTP id d9443c01a7336-2166360285dso12945175ad.1 for ; Mon, 09 Dec 2024 21:46:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733809617; x=1734414417; darn=lists.denx.de; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/UThxgy/S4KPs2urw5n6bTeYN7I33WIE1SAn71dThN4=; b=Mos4dXWn/V6DP46SX7gA+pUk4Fof715X9V54HJZTfOMYQUx8o/WBfud8tQXiZn73bI l5I+McJqHHo8KKZ2XftOwTVn7+0epwwInN8c1zd+NyXxBkBCHcjHzMtaSVZwWvwX8eVN WrstA6dRRDuT5MeoyisRzG5FWFz8RBECKANLWw0IdAl37Qta7gnPZr6RPWDNtZ4cUw6G bLIB768whcWaQ0qvfanyfSIYaYJ/QFugD+CSJvnShEyslekCLR2NUN6iF1xXE3kHrqlq B2hcIUjbOrrB/JRTnKj+unqfCT2tjSvb4fUAGXj9MhafEDjLGSc5xjPPGlVKsTAr0qcY zZsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733809617; x=1734414417; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/UThxgy/S4KPs2urw5n6bTeYN7I33WIE1SAn71dThN4=; b=NzLJZQDnUhb31N5sr4dHt26zmMEm6yziYWV9yiN7wbEWJjme5GHaCbr/UH1Z6YwFt0 inu+KGJK9IKSCu0ZrlEN+9uUSC0bA3ajeMnMJxHmxdzbT6ytgDkkayFqGd/jDRc+dR74 eZ1gAyrwGaoUOj2GUmjMdqw54twvsogvRefq/DdqdfE5KWsZH+O1nv/aua9XBCnvGStx Ina4HgD49X++VpQNbatLqA3rN0PkfmtB+6lWGU2mz6Bt4ANG8aZogU0GhbgschGZKNjM jWccaGuYt0ep4UVd9clZR9SC/xgICj3sjdq3mxVPH1U46VRqa71MOSksb/jkJPFRj/Pz zu1A== X-Gm-Message-State: AOJu0Yyq0w9qRtyuGVtw/2EvwwJSlyQfo/H2TUDdFepSnPPX9R33rJjm 95uVJRdE5JaAyBopCaXHDXgerE2Rf/NBkdaV8pIVn84sD5bt3rKU X-Gm-Gg: ASbGnctCb4X3t+bCC3k1JCwy1yTPPFgp9TrZIkBRuMLmVAQivOnEEtf64YLXjo6rdC9 EB9HCvlx5m2nHYNVvbRZPQI4LE2E9oKAaY/p91/YcE279Mrl4a9M4ur8t6tEk4BHu0oae0T7RwP 6SRBPzlcal3n/TzmDPunnW45SyUqSgCtbbCdZylLI06G0nvhbAJhSduj1LxJK/pWVrgkBBy00d+ jxN4sxhjuzAoZLMcGeb/HhB4SOzX0DRmpA9kG0s9UVqZa6NglkcmCoYccRXrQtK8XJ9TrsMepdz wn5rl2mZ1GFDw17ANcjRLOU= X-Google-Smtp-Source: AGHT+IHe1ase/s2858mqqdbJrOv0XLEz311+SA7NU3FB+gytZ4ulZjZy1j8lKjXlGsmnGBit6vtUlA== X-Received: by 2002:a17:903:110f:b0:212:514:b30a with SMTP id d9443c01a7336-21614d1d9ccmr224703545ad.12.1733809617102; Mon, 09 Dec 2024 21:46:57 -0800 (PST) Received: from per1cycle.per1cycle (n220246100016.netvigator.com. [220.246.100.16]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-216312353f6sm46570825ad.84.2024.12.09.21.46.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Dec 2024 21:46:56 -0800 (PST) Date: Tue, 10 Dec 2024 13:46:48 +0800 From: Huan Zhou To: Yixun Lan Cc: u-boot@lists.denx.de, Ben Dooks , Marcel Ziswiler , Bin Meng , Dan Carpenter , Frieder Schrempf , Heinrich Schuchardt , Jonas =?utf-8?B?U2Nod8O2YmVs?= , Kever Yang , Leo , Michal Simek , Nishanth Menon , Padmarao Begari , Quentin Schulz , Randolph , Rick Chen , Samuel Holland , Sumit Garg , Svyatoslav Ryhel , Tom Rini , Yu Chien Peter Lin , Kongyang Liu Subject: Re: [PATCH v5 0/2] riscv: spacemit: add support for bananapi-f3 Message-ID: <20241210054648.eyynf3toadycgt2p@per1cycle.per1cycle> References: <20241209-pickup-bpif3-v5-0-92f801b7c6c1@gmail.com> <20241210020441-GYA1904091@gentoo> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241210020441-GYA1904091@gentoo> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Tue, Dec 10, 2024 at 10:04:41AM +0800, Yixun Lan wrote: > Hi Huan: > > I have a few comments.. and will put some in separated patch > > First, it's always your responsibility to collect the tags when gotit, thx. > you sending out new version, as I see you missed Leo's review tag in v2 > and Marcel's tested tag in v4 > > P.S: You can rely on maintainer to collect tags of the last version > if no real changes but only tags added.. thx for reminding. > > On 10:00 Mon 09 Dec , Huan Zhou wrote: > > Banana Pi F3 board is a industrial grade RISC-V development board, it > > design with SpacemiT K1 8 core RISC-V chip, CPU integrates 2.0 TOPs AI > > computing power. 4G DDR and 16G eMMC onboard. 2x GbE Ethernet port, 4x USB > > 3.0 and PCIe for M.2 interface, support HDMI and Dual MIPI-CSI Camera. > > > > This patch introduces fundamental support for the Banana Pi F3 board, > > encompassing UART, CPU, and PLIC support. This ensures that U-Boot can > > operate in serial console mode. > > > > Changes in v5: > > - Formal the name from Bananapif3 -> Banana Pi BPI-F3 > > - Trailing whitespace > > - New blank line at EOF in spacemit/index.rst > > - Link to v4: https://lore.kernel.org/r/20241129-pickup-bpif3-v4-0-e99fabf66e33@gmail.com > > > > Changes in v4: > > - Change uart compatible in k1.dtsi in v3, cause related driver in not implemented in u-boot. > > - Update doc, show how to validate the patch. > > - Update maintainer, remove kongyang cause he lefted. > > - Link to v3: https://lore.kernel.org/r/20241114-pickup-bpif3-v3-0-98a45802ab79@gmail.com > > > > Changes in v3: > > - Add base commit > > - Clear redifinition warning while building in UART_IIR_ID > > - Change underscore to dash in bananapi*f3 > > - Update maintainer > > - link to v2 https://lore.kernel.org/u-boot/20240718043329.1500-1-seashell11234455@gmail.com/ > > > > Changes in v2: > > - Change license to GPL-2.0-or-later > > - Add memory node for dts > > - Add ft_board_setup function for kernel memory init > > - Use default prompt > > - links to v1 https://lore.kernel.org/u-boot/20240714150828.736-1-seashell11234455@gmail.com/ > > > > Signed-off-by: Huan Zhou > > Signed-off-by: Kongyang Liu > > --- > > Kongyang Liu (2): > > riscv: spacemit: bananapi_f3: initial support added > > doc: spacemit: bananapi_f3: document Banana Pi F3 board > > > > arch/riscv/Kconfig | 5 + > > arch/riscv/cpu/k1/Kconfig | 18 ++ > > arch/riscv/cpu/k1/Makefile | 6 + > > arch/riscv/cpu/k1/cpu.c | 9 + > > arch/riscv/cpu/k1/dram.c | 54 ++++ > > arch/riscv/dts/Makefile | 1 + > > arch/riscv/dts/k1-bananapi-f3.dts | 25 ++ > > arch/riscv/dts/k1.dtsi | 459 +++++++++++++++++++++++++++++++++ > > board/spacemit/bananapi-f3/Kconfig | 25 ++ > > board/spacemit/bananapi-f3/MAINTAINERS | 6 + > > board/spacemit/bananapi-f3/Makefile | 5 + > > board/spacemit/bananapi-f3/board.c | 9 + > > configs/bananapi-f3_defconfig | 20 ++ > > doc/board/index.rst | 1 + > > doc/board/spacemit/bananapi-f3.rst | 86 ++++++ > > doc/board/spacemit/index.rst | 9 + > > include/configs/bananapi-f3.h | 13 + > > 17 files changed, 751 insertions(+) > > --- > > base-commit: 40c45a57974bdb09fffa31dde65ddf69e5de53eb > > change-id: 20241112-pickup-bpif3-245ab208b9a4 > > > > Best regards, > > -- > > Huan Zhou > > > > -- > Yixun Lan (dlan) > Gentoo Linux Developer > GPG Key ID AABEFD55