Re: [PATCH 4/6] blk: Make block subsystems select BLK

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1266 bytes --]

On Mon, Dec 23, 2024 at 06:31:58PM +0000, Peter Robinson wrote:
> On Fri, 20 Dec 2024 at 22:36, Tom Rini <trini@konsulko.com> wrote:
> 
> > The BLK symbol has a few meanings, one of which is that it controls the
> > driver model portion of a "block device". Rather than having this hidden
> > symbol be "default y if ..." it should be select'd by the various block
> > subsystems.
> >
> > Signed-off-by: Tom Rini <trini@konsulko.com>
> >
> 
> Just a minor query against the USB change, other than that the rest looks
> fine.
[snip]
> > diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
> > index 960b6a906ac4..99c6649e4178 100644
> > --- a/drivers/usb/Kconfig
> > +++ b/drivers/usb/Kconfig
> > @@ -1,5 +1,6 @@
> >  menuconfig USB
> >         bool "USB support"
> > +       select BLK
> >
> 
> Shouldn't this be against USB_STORAGE further down the file?

So, this is a 1:1 translation of what we have today. That said, it
likely could be done at the USB_STORAGE level for USB host, and
USB_FUNCTION_MASS_STORAGE for gadget (the entry for CMD_USB_MASS_STORAGE
is depends on BLK) ? I was slightly worried about opening up a number of
problems if I poked too hard on this area and didn't want the series to
get too big.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]