From: Tom Rini <trini@konsulko.com>
To: Kever Yang <kever.yang@rock-chips.com>
Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>,
Simon Glass <sjg@chromium.org>, Bin Meng <bmeng.cn@gmail.com>,
u-boot@lists.denx.de
Subject: Re: [PATCH 2/2] config: efi-x86_payload: Enable DEBUG_UART
Date: Mon, 6 Jan 2025 16:04:58 -0600 [thread overview]
Message-ID: <20250106220458.GE3476@bill-the-cat> (raw)
In-Reply-To: <3a7f8b43-288c-4951-a781-c9d7139bab2a@rock-chips.com>
[-- Attachment #1: Type: text/plain, Size: 887 bytes --]
On Mon, Jan 06, 2025 at 02:46:53PM +0800, Kever Yang wrote:
> Hi Heinrich and Simon,
>
> I send these two change because I want to fix the build error
> below(from[1]) which is for disable the DEBUG_UART[2].
> Do you have clear suggestion on how to do this in efi_stub, since I have no
> idea about this module, so I just follow how
> it works in other serial driver.
Can you please remind me what got us going in this direction to start
with? Is it related to (in the rockchip tree):
commit 968c5682c14fe26bcabccf925157b5afc4427ad0
Author: Lukasz Czechowski <lukasz.czechowski@thaumatec.com>
Date: Wed Sep 18 15:01:53 2024 +0200
ram: rockchip: Fix dependency of RAM_ROCKCHIP_DEBUG
And in turn, why is that even "default y" ? Having something that
required DEBUG_UART be enabled sounds like we're a bit off in the wrong
direction. Thanks.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2025-01-06 22:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-28 3:47 [PATCH 1/2] efi_stub: Sync the debug UART definition like other platform Kever Yang
2024-11-28 3:47 ` [PATCH 2/2] config: efi-x86_payload: Enable DEBUG_UART Kever Yang
2025-01-03 16:16 ` Heinrich Schuchardt
2025-01-04 1:11 ` Heinrich Schuchardt
2025-01-04 19:29 ` Simon Glass
2025-01-04 23:02 ` Heinrich Schuchardt
2025-01-06 6:46 ` Kever Yang
2025-01-06 12:40 ` Simon Glass
2025-01-06 22:04 ` Tom Rini [this message]
2024-11-29 3:22 ` [PATCH 1/2] efi_stub: Sync the debug UART definition like other platform Kever Yang
2024-11-29 3:28 ` Tom Rini
2024-12-09 13:28 ` Simon Glass
2025-01-03 15:43 ` Heinrich Schuchardt
2025-01-06 3:33 ` Kever Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250106220458.GE3476@bill-the-cat \
--to=trini@konsulko.com \
--cc=bmeng.cn@gmail.com \
--cc=kever.yang@rock-chips.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox