Re: [PATCH 0/8] efi_loader: Complete the bootflow_efi() test

Simon Glass
2025-01-07T12:15:22Z

Hi Heinrich,

On Mon, 6 Jan 2025 at 10:00, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> On 06.01.25 15:47, Simon Glass wrote:
> > This test was hamstrung in code review so this series is an attempt to
> > complete the intended functionality:
> >
> > - Check memory allocations look correct
> > - Check that exit-boot-services removes active-DMA devices
> > - Check that the bootflow is still present after testapp finishes
> >
> > The EFI functionality duplicates bootm_announce_and_cleanup() and still
> > uses the defunct board_quiesce_devices() so a nice cleanup would be to
> > call the bootm function instead, with suitable modifications. That would
> > allow bootstage to work too.
> >
> > This series is based on sjg/master since the EFI logging was rejected so
> > far.
>
> Yes, it was rejected because a solution at the lib/log.c level would be
> more generic.

As I mentioned, that idea isn't suitable for programmatic use.

>
> Tom suggested not to send patches that are for private enjoyment to the
> mailing list.

My contributions to U-Boot are only ever about private enjoyment :-)

Do you have any comments on the patches?

Regards,
Simon