Re: [PATCH 0/8] efi_loader: Complete the bootflow_efi() test

Heinrich Schuchardt
2025-01-06T17:00:20Z

On 06.01.25 15:47, Simon Glass wrote:
> This test was hamstrung in code review so this series is an attempt to
> complete the intended functionality:
>
> - Check memory allocations look correct
> - Check that exit-boot-services removes active-DMA devices
> - Check that the bootflow is still present after testapp finishes
>
> The EFI functionality duplicates bootm_announce_and_cleanup() and still
> uses the defunct board_quiesce_devices() so a nice cleanup would be to
> call the bootm function instead, with suitable modifications. That would
> allow bootstage to work too.
>
> This series is based on sjg/master since the EFI logging was rejected so
> far.

Yes, it was rejected because a solution at the lib/log.c level would be
more generic.

Tom suggested not to send patches that are for private enjoyment to the
mailing list.

Best regards

Heinrich

>
>
> Simon Glass (8):
> sandbox: Make USB controller as having active DMA
> efi_loader: Fix display of addresses in log
> efi_loader: Return the memory map in pointer format
> efi_loader: Correct bounce-buffer setup
> efi_loader: Check memory allocations in bootflow_efi test()
> efi_loader: Update testapp to get memory map correctly
> efi_loader: Check that the bootflow is not removed by app
> efi_loader: Test that active-DMA devices are removed
>
> drivers/usb/host/usb-sandbox.c | 1 +
> lib/efi_loader/efi_log.c | 5 +--
> lib/efi_loader/efi_memory.c | 9 ++--
> lib/efi_loader/testapp.c | 37 ++++++++++++++++
> test/boot/bootflow.c | 78 +++++++++++++++++++++++++++++++++-
> 5 files changed, 122 insertions(+), 8 deletions(-)
>