From: Tom Rini <trini@konsulko.com>
To: Simon Glass <sjg@chromium.org>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
Anand Moon <linux.amoon@gmail.com>, Bin Meng <bmeng.cn@gmail.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Jerome Forissier <jerome.forissier@linaro.org>,
Masahisa Kojima <kojima.masahisa@socionext.com>,
Michal Simek <michal.simek@amd.com>,
Patrick Delaunay <patrick.delaunay@foss.st.com>,
Patrick Rudolph <patrick.rudolph@9elements.com>,
Raymond Mao <raymond.mao@linaro.org>,
Sughosh Ganu <sughosh.ganu@linaro.org>,
Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
Subject: Re: [PATCH v2 22/33] emulation: Use bloblist to hold tables
Date: Thu, 9 Jan 2025 16:28:19 -0600 [thread overview]
Message-ID: <20250109222819.GE3476@bill-the-cat> (raw)
In-Reply-To: <20250106143229.3023771-23-sjg@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 1287 bytes --]
On Mon, Jan 06, 2025 at 07:32:18AM -0700, Simon Glass wrote:
> QEMU can have its own internal ACPI and SMBIOS tables. At present U-Boot
> copies out the SMBIOS tables but points directly to the ACPI ones.
>
> The ACPI tables are not aligned on a 4KB boundary, which means that UPL
> cannot use them directly, since it uses a reserved-memory node for the
> tables and that it assumed (by EDK2) to be 4KB-aligned.
>
> On x86, QEMU completely takes over the generation of these tables, thus
> making it difficult to use any common code.
>
> Adjust the logic to fit within the existing table-generation code. Use a
> bloblist always and ensure that the ACPI tables is placed in an aligned
> region. Set a size of 8K for QEMU. This does not actually put all the
> tables in one place, for QEMU, since it currently adds a pointer to the
> tables in QFW.
>
> On ARM, enable bloblist so that SMBIOS tables can be added to the
> bloblist.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
Commits that are "big external project is doing things wrong, we need to
work around it" are at best worrisome to me. If re-thinking what you're
doing here isn't right, re-wording what you're doing to not be negative
about other projects is what's needed then.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2025-01-09 22:28 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 14:31 [PATCH v2 00/33] upl: Prerequite patches for updated spec Simon Glass
2025-01-06 14:31 ` [PATCH v2 01/33] bloblist: add api to get blob with size Simon Glass
2025-01-06 14:31 ` [PATCH v2 02/33] bloblist: Drop BSD license Simon Glass
2025-01-07 10:36 ` Ilias Apalodimas
2025-01-07 12:04 ` Simon Glass
2025-01-06 14:31 ` [PATCH v2 03/33] bloblist: Make BLOBLIST_ALLOC the default Simon Glass
2025-01-06 21:41 ` Tom Rini
2025-01-09 15:01 ` Simon Glass
2025-01-09 16:42 ` Tom Rini
2025-01-10 13:38 ` Simon Glass
2025-01-06 14:32 ` [PATCH v2 04/33] abuf: Provide a way to get the buffer address Simon Glass
2025-01-06 14:32 ` [PATCH v2 05/33] abuf: Allow use in host tools Simon Glass
2025-01-06 14:32 ` [PATCH v2 06/33] abuf: Provide a constant buffer Simon Glass
2025-01-06 14:32 ` [PATCH v2 07/33] cpu: Provide a way to get the physical-address size Simon Glass
2025-01-06 14:32 ` [PATCH v2 08/33] serial: Support info() method in ns16550 xPL with UPL Simon Glass
2025-01-06 14:32 ` [PATCH v2 09/33] mkimage: Update map_to_sysmem() to match its prototype Simon Glass
2025-01-06 14:32 ` [PATCH v2 10/33] x86: Enable meminfo command Simon Glass
2025-01-06 14:32 ` [PATCH v2 11/33] x86: Show the timestamp counter with bdinfo Simon Glass
2025-01-06 14:32 ` [PATCH v2 12/33] ofnode: Use 4K for a default tree-size Simon Glass
2025-01-08 18:33 ` Tom Rini
2025-01-09 12:37 ` Simon Glass
2025-01-06 14:32 ` [PATCH v2 13/33] ofnode: Indicate when out of space in a few places Simon Glass
2025-01-08 18:25 ` Tom Rini
2025-01-06 14:32 ` [PATCH v2 14/33] ofnode: Update of_add_subnode() to indicate name is alloced Simon Glass
2025-01-06 14:32 ` [PATCH v2 15/33] boot: Rename fit_image_get_data() Simon Glass
2025-01-06 14:32 ` [PATCH v2 16/33] boot: Rename fit_image_get_data_and_size() Simon Glass
2025-01-06 14:32 ` [PATCH v2 17/33] boot: Update fit_image_get_emb_data to use abuf Simon Glass
2025-01-08 18:25 ` Tom Rini
2025-01-09 12:36 ` Simon Glass
2025-01-09 15:09 ` Tom Rini
2025-01-09 15:14 ` Simon Glass
2025-01-09 18:08 ` Tom Rini
2025-01-10 13:39 ` Simon Glass
2025-01-10 16:17 ` Tom Rini
2025-01-10 19:23 ` Simon Glass
2025-01-10 21:15 ` Tom Rini
2025-01-06 14:32 ` [PATCH v2 18/33] boot: Use fit_image_get_data() to get data Simon Glass
2025-01-06 14:32 ` [PATCH v2 19/33] boot: Update fit_image_get_data() to use abuf Simon Glass
2025-01-06 14:32 ` [PATCH v2 20/33] test: Fix inpected typo in upl test Simon Glass
2025-01-06 14:32 ` [PATCH v2 21/33] emulation: fdt: Relax condition for OF_HAS_PRIOR_STAGE Simon Glass
2025-01-06 21:40 ` Tom Rini
2025-01-09 15:01 ` Simon Glass
2025-01-09 15:14 ` Tom Rini
2025-01-10 13:38 ` Simon Glass
2025-01-06 14:32 ` [PATCH v2 22/33] emulation: Use bloblist to hold tables Simon Glass
2025-01-09 22:28 ` Tom Rini [this message]
2025-01-06 14:32 ` [PATCH v2 23/33] x86: Create more space for SPL with qemu-x86_64 Simon Glass
2025-01-06 14:32 ` [PATCH v2 24/33] pci: video: Set up the pixel-format field Simon Glass
2025-01-06 14:32 ` [PATCH v2 25/33] x86: Show an error if video fails Simon Glass
2025-01-06 14:32 ` [PATCH v2 26/33] x86: Support jumping to a UPL image Simon Glass
2025-01-06 14:32 ` [PATCH v2 27/33] x86: Enable UPL handoff for SPL Simon Glass
2025-01-06 14:32 ` [PATCH v2 28/33] x86: Move tables to use SZ macros Simon Glass
2025-01-06 14:32 ` [PATCH v2 29/33] x86: Align the SMBIOS table to a 4K boundary Simon Glass
2025-01-06 14:32 ` [PATCH v2 30/33] x86: emulation: Enable bloblist Simon Glass
2025-01-06 14:32 ` [PATCH v2 31/33] dm: core: Clarify behaviour of ofnode_name_eq() Simon Glass
2025-01-06 14:32 ` [PATCH v2 32/33] dm: core: Provide ofnode_name_eq_unit() to accept a unit address Simon Glass
2025-01-06 14:32 ` [PATCH v2 33/33] dm: core: Provide ofnode_find_subnode_unit() Simon Glass
2025-01-06 21:42 ` [PATCH v2 00/33] upl: Prerequite patches for updated spec Tom Rini
2025-01-08 18:37 ` Tom Rini
2025-01-09 12:37 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250109222819.GE3476@bill-the-cat \
--to=trini@konsulko.com \
--cc=bmeng.cn@gmail.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jerome.forissier@linaro.org \
--cc=kojima.masahisa@socionext.com \
--cc=linux.amoon@gmail.com \
--cc=michal.simek@amd.com \
--cc=patrick.delaunay@foss.st.com \
--cc=patrick.rudolph@9elements.com \
--cc=raymond.mao@linaro.org \
--cc=sjg@chromium.org \
--cc=sughosh.ganu@linaro.org \
--cc=tuomas.tynkkynen@iki.fi \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox