Re: [PATCH 2/8] efi_loader: Fix display of addresses in log

Ilias Apalodimas
2025-01-07T13:37:50Z

Hi Simon,

On Mon, 6 Jan 2025 at 16:48, Simon Glass <sjg@chromium.org> wrote:
>
> The allocate/free-pages functions return an address, so there is no need
> to convert it. Fix this.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Fixes: c824a96d76d ("efi_loader: Use the log with memory-related...")

I can't find that commit in -master. Is there anything I am missing?

Thanks
/Ilias
> ---
>
> lib/efi_loader/efi_log.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/lib/efi_loader/efi_log.c b/lib/efi_loader/efi_log.c
> index 4b9c6727fe7..ad490bb431c 100644
> --- a/lib/efi_loader/efi_log.c
> +++ b/lib/efi_loader/efi_log.c
> @@ -340,8 +340,7 @@ void show_rec(int seq, struct efil_rec_hdr *rec_hdr)
> show_ulong("pgs", (ulong)rec->pages);
> show_addr("mem", (ulong)rec->memory);
> if (rec_hdr->ended) {
> - show_addr("*mem",
> - (ulong)map_to_sysmem((void *)rec->e_memory));
> + show_addr("*mem", rec->e_memory);
> show_ret(rec_hdr->e_ret);
> }
> break;
> @@ -349,7 +348,7 @@ void show_rec(int seq, struct efil_rec_hdr *rec_hdr)
> case EFILT_FREE_PAGES: {
> struct efil_free_pages *rec = start;
>
> - show_addr("mem", map_to_sysmem((void *)rec->memory));
> + show_addr("mem", rec->memory);
> show_ulong("pag", (ulong)rec->pages);
> if (rec_hdr->ended)
> show_ret(rec_hdr->e_ret);
> --
> 2.34.1
>