Re: [PATCH v4 20/20] imx95_evk: add i.MX95 19x19 EVK board basic support

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 2777 bytes --]

On Thu, Jan 16, 2025 at 09:03:35PM +0100, Marek Vasut wrote:
> On 1/16/25 8:42 PM, Tim Harvey wrote:
> > On Thu, Jan 16, 2025 at 11:38 AM Tim Harvey <tharvey@gateworks.com> wrote:
> > > 
> > > On Wed, Jan 15, 2025 at 5:30 AM Alice Guo <alice.guo@oss.nxp.com> wrote:
> > > > 
> > > > From: Ye Li <ye.li@nxp.com>
> > > > 
> > > > This patch adds i.MX95 19x19 EVK board basic support.
> > > > 
> > > > Messaging unit for EdgeLock Secure Enclave, messaging unit for System
> > > > Manager, uSDHC for SD Card, gpio, lpuart are supported now.
> > > > 
> > > > Signed-off-by: Ye Li <ye.li@nxp.com>
> > > > Signed-off-by: Alice Guo <alice.guo@nxp.com>
> > > > Reviewed-by: Peng Fan <peng.fan@nxp.com>
> > > > ---
> > > <snip...>
> > > > diff --git a/board/freescale/imx95_evk/imx95_evk.c b/board/freescale/imx95_evk/imx95_evk.c
> > > > new file mode 100644
> > > > index 0000000000000000000000000000000000000000..1ed15ca47b157067a7376b0b32101dc7f9899f4f
> > > > --- /dev/null
> > > > +++ b/board/freescale/imx95_evk/imx95_evk.c
> > > > @@ -0,0 +1,54 @@
> > > > +// SPDX-License-Identifier: GPL-2.0+
> > > > +/*
> > > > + * Copyright 2025 NXP
> > > > + */
> > > > +
> > > > +#include <env.h>
> > > > +#include <init.h>
> > > > +#include <asm/global_data.h>
> > > > +#include <asm/arch-imx9/ccm_regs.h>
> > > > +#include <asm/arch/clock.h>
> > > > +#include <fdt_support.h>
> > > > +#include <asm/io.h>
> > > > +#include <linux/bitfield.h>
> > > > +#include <linux/bitops.h>
> > > > +#include <linux/delay.h>
> > > > +#include <miiphy.h>
> > > > +#include <netdev.h>
> > > > +#include <asm/gpio.h>
> > > > +#include <asm/mach-imx/sys_proto.h>
> > > > +#include <scmi_agent.h>
> > > > +#include <scmi_protocols.h>
> > > > +#include "../../../dts/upstream/src/arm64/freescale/imx95-clock.h"
> > > > +#include "../../../dts/upstream/src/arm64/freescale/imx95-power.h"
> > > 
> > > Hi Alice,
> > > 
> > > Most of the above are not needed (and should be alphabetized anyway)
> > > 
> > > The only ones needed are:
> > > #include <asm/arch/clock.h>
> > > #include <asm/gpio.h>
> > > #include <asm/mach-imx/sys_proto.h>
> > > 
> > > > +
> > > > +DECLARE_GLOBAL_DATA_PTR;
> > > 
> > > not needed as you don't use gd
> > > 
> > > Best Regards,
> > > 
> > > Tim
> > 
> > Hi Alic,
> > 
> > One more thing to do for next series. Refresh your
> > imx95_19x19_evk_defconfig as its very out of sync:
> > 
> > make imx95_19x19_evk_defconfig
> > make savedefconfig
> > cp defconfig configs/imx95_19x19_evk_defconfig
> And please enable CONFIG_FIT and CONFIG_FIT_VERBOSE .

Which should already be there if using bootstd to boot and not distro
boot scripts, another thing that should be done now and not later.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]