public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Gabriel Dalimonte <gabriel.dalimonte@gmail.com>
To: u-boot@lists.denx.de
Cc: Gabriel Dalimonte <gabriel.dalimonte@gmail.com>,
	Heinrich Schuchardt <xypron.glpk@gmx.de>,
	Ilias Apalodimas <ilias.apalodimas@linaro.org>,
	Simon Glass <sjg@chromium.org>, Tom Rini <trini@konsulko.com>
Subject: [PATCH 6/6] efi_loader: support file rename in SetInfo()
Date: Wed, 22 Jan 2025 00:32:31 -0500	[thread overview]
Message-ID: <20250122053232.17365-7-gabriel.dalimonte@gmail.com> (raw)
In-Reply-To: <20250122053232.17365-1-gabriel.dalimonte@gmail.com>

Following the UEFI specification. The specification did not seem to
delineate if file_name was explicitly a file name only, or could
include paths to move the file to a different directory. The more
generous interpretation of supporting paths was selected.

Signed-off-by: Gabriel Dalimonte <gabriel.dalimonte@gmail.com>
---

 lib/efi_loader/efi_file.c | 48 +++++++++++++++++++++++++++++++++++----
 1 file changed, 43 insertions(+), 5 deletions(-)

diff --git a/lib/efi_loader/efi_file.c b/lib/efi_loader/efi_file.c
index e72bc36aca..f3d643a057 100644
--- a/lib/efi_loader/efi_file.c
+++ b/lib/efi_loader/efi_file.c
@@ -981,11 +981,49 @@ static efi_status_t EFIAPI efi_file_setinfo(struct efi_file_handle *file,
 		pos = new_file_name;
 		utf16_utf8_strcpy(&pos, info->file_name);
 		if (strcmp(new_file_name, filename)) {
-			/* TODO: we do not support renaming */
-			EFI_PRINT("Renaming not supported\n");
-			free(new_file_name);
-			ret = EFI_ACCESS_DENIED;
-			goto out;
+			int dlen;
+			int rv;
+			char *new_path;
+
+			if (set_blk_dev(fh)) {
+				free(new_file_name);
+				ret = EFI_DEVICE_ERROR;
+				goto out;
+			}
+			dlen = filename - fh->path;
+			new_path = calloc(1, dlen + strlen(new_file_name) + 1);
+			if (!new_path) {
+				free(new_file_name);
+				ret = EFI_OUT_OF_RESOURCES;
+				goto out;
+			}
+			memcpy(new_path, fh->path, dlen);
+			strcpy(new_path + dlen, new_file_name);
+			sanitize_path(new_path);
+			rv = fs_exists(new_path);
+			if (rv) {
+				free(new_path);
+				free(new_file_name);
+				ret = EFI_ACCESS_DENIED;
+				goto out;
+			}
+			/* fs_exists() calls fs_close(), so open file system again */
+			if (set_blk_dev(fh)) {
+				free(new_path);
+				free(new_file_name);
+				ret = EFI_DEVICE_ERROR;
+				goto out;
+			}
+			rv = fs_rename(fh->path, new_path);
+			if (rv) {
+				free(new_path);
+				free(new_file_name);
+				ret = EFI_ACCESS_DENIED;
+				goto out;
+			}
+			free(fh->path);
+			fh->path = new_path;
+			ret = EFI_SUCCESS;
 		}
 		free(new_file_name);
 		/* Check for truncation */
-- 
2.34.1


  parent reply	other threads:[~2025-01-22 13:23 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-22  5:32 [PATCH 0/6] add support for renaming to EFI_FILE_PROTOCOL.SetInfo() Gabriel Dalimonte
2025-01-22  5:32 ` [PATCH 1/6] fs: fat: factor out dentry link create/delete Gabriel Dalimonte
2025-01-22  7:08   ` Heinrich Schuchardt
2025-01-26  4:34     ` Gabriel D'Alimonte
2025-01-22  5:32 ` [PATCH 2/6] fs: add rename infrastructure Gabriel Dalimonte
2025-01-22  8:10   ` Heinrich Schuchardt
2025-01-22  9:18     ` Heinrich Schuchardt
2025-01-26  4:38       ` Gabriel D'Alimonte
2025-01-22  5:32 ` [PATCH 3/6] fs: fat: add rename Gabriel Dalimonte
2025-01-22  8:41   ` Heinrich Schuchardt
2025-01-22  5:32 ` [PATCH 4/6] fs: fat: update parent dirs metadata on rename Gabriel Dalimonte
2025-01-22  9:00   ` Heinrich Schuchardt
2025-01-26  4:39     ` Gabriel D'Alimonte
2025-01-22  5:32 ` [PATCH 5/6] efi_loader: move path out of file_handle Gabriel Dalimonte
2025-01-22  5:32 ` Gabriel Dalimonte [this message]
2025-02-04 12:53   ` [PATCH 6/6] efi_loader: support file rename in SetInfo() Ilias Apalodimas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250122053232.17365-7-gabriel.dalimonte@gmail.com \
    --to=gabriel.dalimonte@gmail.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox