From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A65D0C0218D for ; Wed, 29 Jan 2025 01:36:00 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 07779807C4; Wed, 29 Jan 2025 02:35:59 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id BDB78811CA; Wed, 29 Jan 2025 02:35:57 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id 4CF0A807A7 for ; Wed, 29 Jan 2025 02:35:55 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C831D497; Tue, 28 Jan 2025 17:36:20 -0800 (PST) Received: from minigeek.lan (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0F4F73F5A1; Tue, 28 Jan 2025 17:35:52 -0800 (PST) Date: Wed, 29 Jan 2025 01:34:15 +0000 From: Andre Przywara To: "=?UTF-8?B?6buE5Yip5Lqa?=" <1425075683@qq.com> Cc: "Chris Morgan" , "Jagan Teki" , "Jernej Skrabec" , "Maksim Kiselev" , "Michael Walle" , "Samuel Holland" , "Simon Glass" , "SumitGarg" , "Tom Rini" , "u-boot" Subject: Re: [PATCH] arm: The CHIP DIP SCAN option should not be displayed in other mach Message-ID: <20250129013415.5be2bbae@minigeek.lan> In-Reply-To: References: <20250128155542.426d3d8a@donnerap.manchester.arm.com> Organization: Arm Ltd. X-Mailer: Claws Mail 4.2.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Wed, 29 Jan 2025 09:28:56 +0800 "=E9=BB=84=E5=88=A9=E4=BA=9A" <1425075683@qq.com> wrote: Hi LiYa, Happy New Year! > That's the first question.Now I see this option in menuconfig, it should = not be available on other models.I used the following command: >     export CROSS_COMPILE=3Darm-none-eabi- ARCH=3Darm >     make stm32h750-art-pi_defconfig >     make menuconfig >     ARM architecture  --->Enable DIPs detection for CHI= P board (NEW) >=20 > So I implemented this patch to fix it. > But I find that the root cause is that this  > config is not included in if ARCH_SUNXI.  Yes, as I mentioned, you are right, it shouldn't be there, that's a bug when this option was introduced. > This is the second problem.I tried to include it,  > but got a compiler error. >=20 > diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig > index ba1b1541437..b467ab098c0 100644 > --- a/arch/arm/mach-sunxi/Kconfig > +++ b/arch/arm/mach-sunxi/Kconfig > @@ -1133,8 +1133,6 @@ config BLUETOOTH_DT_DEVICE_FIXUP >   >  source "board/sunxi/Kconfig" >   > -endif > - Ah, you just need to move that "source" line above together with the endif, so that it ends up as: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D config CHIP_DIP_SCAN .... source "board/sunxi/Kconfig" endif =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D That worked for me. If you can confirm this, please send a v2 with that change, and I am happy to take it. Cheers, Andre >  config CHIP_DIP_SCAN >   bool "Enable DIPs detection for CHIP board" >   select SUPPORT_EXTENSION_SCAN > @@ -1143,3 +1141,6 @@ config CHIP_DIP_SCAN >   select W1_EEPROM >   select W1_EEPROM_DS24XXX >   select CMD_EXTENSION > + > + > +endif >=20 >=20 >=20 > The error message for running make menuconfig is as follows: > arch/arm/mach-sunxi/Kconfig:1146: 'endif' in different file than 'if' > arch/arm/mach-sunxi/Kconfig:1: location of the 'if' > arch/arm/Kconfig:2417: 'endmenu' in different file than 'menu' > arch/arm/mach-sunxi/Kconfig:1: location of the 'menu >=20 >=20 > Cheers, > LiYa >=20 >=20 > ------------------ Original ------------------ > From: = "Andre Przywara" = = Date: Tue, Jan 28, 2025 11:55 PM > To: "=E9=BB=84=E5=88=A9=E4=BA=9A"<1425075683@qq.com>; > Cc: "Chris Morgan" Subject: Re: [PATCH] arm: The CHIP DIP SCAN option should not be dis= played in other mach >=20 >=20 >=20 > On Tue, 28 Jan 2025 21:37:37 +0800 > 1425075683@qq.com wrote: >=20 > Hi, >=20 > > From: Liya Huang <1425075683@qq.com> > >=20 > > When I use mach STM32, > > menuconfig sees this option; It bothers me. > > I observed that the root cause was that the > > option was not included in the endif, > > but when I tried to fix it, an error occurred. >=20 > Can you say what the error is, exactly? > Because you are right, it should be before the endif. > I moved that, and compiled it for all Allwinner boards, which worked. > So what is the problem there, exactly? >=20 > Cheers, > Andre >=20 > > I didn't find a solution. Only deponds can be used for hiding. > >=20 > > Signed-off-by: Liya Huang <1425075683@qq.com> > > --- > >=20 > >  arch/arm/mach-sunxi/Kconfig | 1 + > >  1 file changed, 1 insertion(+) > >=20 > > diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconf= ig > > index ba1b1541437..48dd1e68363 100644 > > --- a/arch/arm/mach-sunxi/Kconfig > > +++ b/arch/arm/mach-sunxi/Kconfig > > @@ -1137,6 +1137,7 @@ endif > > =20 > >  config CHIP_DIP_SCAN > >  bool "Enable DIPs detection for CHIP board" > > + depends on ARCH_SUNXI > >  select SUPPORT_EXTENSION_SCAN > >  select W1 > >  select W1_GPIO