U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yixun Lan <dlan@gentoo.org>
To: Yao Zi <ziyao@disroot.org>
Cc: Rick Chen <rick@andestech.com>, Leo <ycliang@andestech.com>,
	Tom Rini <trini@konsulko.com>,
	Conor Dooley <conor.dooley@microchip.com>,
	Mayuresh Chitale <mchitale@ventanamicro.com>,
	Heinrich Schuchardt <xypron.glpk@gmx.de>,
	Simon Glass <sjg@chromium.org>,
	u-boot@lists.denx.de
Subject: Re: [RFC PATCH 0/3] Unify implementation of cleanup_before_linux() for RISC-V ports
Date: Wed, 29 Jan 2025 11:28:38 +0000	[thread overview]
Message-ID: <20250129112838-GYA50750@gentoo> (raw)
In-Reply-To: <20250123091134.63634-2-ziyao@disroot.org>

Hi Yao:

I think you can just drop "RFC" in next version

On 09:11 Thu 23 Jan     , Yao Zi wrote:
> This series introduces a generic version of cleanup_before_linux(),
> because most RISC-V SoCs have similar implementation. Ports for generic
> platforms and JH7110 are converted to use it for now: these devices are
> available to me and I have verified that Linux boots with these changes.
> 
thanks, generally I like this direction

> With a quick look at the codebase, I think this could be done for all
> RISC-V ports ultimately. Thanks for your feedback and review.
> 
can you go ahead and further cleanup other boards?

> Yao Zi (3):
>   riscv: add a generic implementation for cleanup_before_linux()
>   riscv: cpu: generic: fallback to generic cleanup_before_linux()
>   riscv: cpu: jh7110: fallback to generic cleanup_before_linux()
> 
>  arch/riscv/cpu/cpu.c            | 17 +++++++++++++++++
>  arch/riscv/cpu/generic/Makefile |  1 -
>  arch/riscv/cpu/generic/cpu.c    | 22 ----------------------
>  arch/riscv/cpu/jh7110/Makefile  |  1 -
>  arch/riscv/cpu/jh7110/cpu.c     | 23 -----------------------
>  5 files changed, 17 insertions(+), 47 deletions(-)
>  delete mode 100644 arch/riscv/cpu/generic/cpu.c
>  delete mode 100644 arch/riscv/cpu/jh7110/cpu.c
> 
> -- 
> 2.48.0
> 

-- 
Yixun Lan (dlan)
Gentoo Linux Developer
GPG Key ID AABEFD55

      parent reply	other threads:[~2025-01-29 11:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-23  9:11 [RFC PATCH 0/3] Unify implementation of cleanup_before_linux() for RISC-V ports Yao Zi
2025-01-23  9:11 ` [RFC PATCH 1/3] riscv: add a generic implementation for cleanup_before_linux() Yao Zi
2025-02-03  3:51   ` Leo Liang
2025-01-23  9:11 ` [RFC PATCH 2/3] riscv: cpu: generic: fallback to generic cleanup_before_linux() Yao Zi
2025-02-03  3:52   ` Leo Liang
2025-01-23  9:11 ` [RFC PATCH 3/3] riscv: cpu: jh7110: " Yao Zi
2025-02-03  3:53   ` Leo Liang
2025-01-29 11:28 ` Yixun Lan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250129112838-GYA50750@gentoo \
    --to=dlan@gentoo.org \
    --cc=conor.dooley@microchip.com \
    --cc=mchitale@ventanamicro.com \
    --cc=rick@andestech.com \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    --cc=ycliang@andestech.com \
    --cc=ziyao@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox