From: Peng Fan <peng.fan@oss.nxp.com>
To: j.ne@posteo.net
Cc: Tom Rini <trini@konsulko.com>, u-boot@lists.denx.de
Subject: Re: [PATCH 2/2] powerpc: mpc8xxx_spi: Catch bad chip variants earlier
Date: Mon, 3 Mar 2025 12:08:38 +0800 [thread overview]
Message-ID: <20250303040838.GB13236@nxa18884-linux> (raw)
In-Reply-To: <20250217-immap-size-v1-2-f9be2e9e7b1a@posteo.net>
Hi,
On Mon, Feb 17, 2025 at 04:48:48PM +0100, J. Neuschäfer via B4 Relay wrote:
>From: "J. Neuschäfer" <j.ne@posteo.net>
>
>Currently, enabling the MPC8xxx SPI driver on an unexpected SoC results
>in a wall of errors because spi8xxx_t isn't defined. This is quite a bad
>experience, so let's catch this kind of issue in mpc8xxx_spi.h.
>
>Signed-off-by: J. Neuschäfer <j.ne@posteo.net>
>---
> arch/powerpc/include/asm/mpc8xxx_spi.h | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/arch/powerpc/include/asm/mpc8xxx_spi.h b/arch/powerpc/include/asm/mpc8xxx_spi.h
>index 2b2095ad481d19a48e1f8d521626a0356773c0b5..3efd4bdcac2c3725a8065b3bb7faa11c78da0c78 100644
>--- a/arch/powerpc/include/asm/mpc8xxx_spi.h
>+++ b/arch/powerpc/include/asm/mpc8xxx_spi.h
>@@ -28,6 +28,8 @@ typedef struct spi8xxx {
> } spi8xxx_t;
> static_assert(sizeof(spi8xxx_t) == 0x1000);
>
>+#else
>+#error "SPI register layout not defined: Unknown chip variant"
> #endif
This cause build error, would you please give a look?:
powerpc: + kmcoge5ne
+In file included from arch/powerpc/include/asm/immap_83xx.h:19,
+ from arch/powerpc/include/asm/ppc.h:24,
+ from arch/powerpc/include/asm/u-boot.h:23,
+ from arch/powerpc/include/asm/global_data.h:98,
+ from lib/asm-offsets.c:15:
+arch/powerpc/include/asm/mpc8xxx_spi.h:32:2: error: #error "SPI register layout not defined: Unknown chip variant"
+ 32 | #error "SPI register layout not defined: Unknown chip variant"
+ | ^~~~~
+make[2]: *** [scripts/Makefile.build:146: lib/asm-offsets.s] Error 1
+make[1]: *** [Makefile:1980: prepare0] Error 2
+make: *** [Makefile:177: sub-make] Error 2
powerpc: + kmeter1
+In file included from arch/powerpc/include/asm/immap_83xx.h:19,
+ from arch/powerpc/include/asm/ppc.h:24,
+ from arch/powerpc/include/asm/u-boot.h:23,
+ from arch/powerpc/include/asm/global_data.h:98,
+ from lib/asm-offsets.c:15:
+arch/powerpc/include/asm/mpc8xxx_spi.h:32:2: error: #error "SPI register layout not defined: Unknown chip variant"
+ 32 | #error "SPI register layout not defined: Unknown chip variant"
+ | ^~~~~
+make[2]: *** [scripts/Makefile.build:146: lib/asm-offsets.s] Error 1
+make[1]: *** [Makefile:1980: prepare0] Error 2
+make: *** [Makefile:177: sub-make] Error 2
microblaze: w+ microblaze-generic
Thanks,
Peng
>
> #endif /* _ASM_MPC8XXX_SPI_H_ */
>
>--
>2.48.0.rc1.219.gb6b6757d772
>
>
next prev parent reply other threads:[~2025-03-03 3:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 15:48 [PATCH 0/2] PowerPC MPC8xxx compile-time checks J. Neuschäfer via B4 Relay
2025-02-17 15:48 ` [PATCH 1/2] powerpc: mpc83xx: Check the size of peripheral structs J. Neuschäfer via B4 Relay
2025-02-17 15:48 ` [PATCH 2/2] powerpc: mpc8xxx_spi: Catch bad chip variants earlier J. Neuschäfer via B4 Relay
2025-03-03 4:08 ` Peng Fan [this message]
2025-03-04 13:00 ` J. Neuschäfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250303040838.GB13236@nxa18884-linux \
--to=peng.fan@oss.nxp.com \
--cc=j.ne@posteo.net \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox