U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Francesco Dolcini <francesco@dolcini.it>
To: Stefan Eichenberger <eichest@gmail.com>
Cc: francesco.dolcini@toradex.com, trini@konsulko.com,
	n-francis@ti.com, s-k6@ti.com, w.egorov@phytec.de,
	emanuele.ghidoli@toradex.com, u-boot@lists.denx.de,
	Stefan Eichenberger <stefan.eichenberger@toradex.com>
Subject: Re: [PATCH v1] board: verdin-am62: fix missing memory fixup call
Date: Tue, 4 Mar 2025 08:09:55 +0100	[thread overview]
Message-ID: <20250304070955.GA6339@francesco-nb> (raw)
In-Reply-To: <20250303181618.41802-1-eichest@gmail.com>

On Mon, Mar 03, 2025 at 07:16:03PM +0100, Stefan Eichenberger wrote:
> From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> 
> The commit bc07851897bd ("board: ti: Pull redundant DDR functions to a
> common location and Fixup DDR size when ECC is enabled") broke DRAM
> support for the Verdin AM62. This was partially fixed with commit
> 3f866c47b582 ("board: verdin-am62: add dram_init_banksize"). However,
> because fixup_memory_node was not called, the Linux kernel was started
> with the wrong memory size on modules with less memory available. This
> resulted in boot failures. Fix this issue by calling fixup_memory_node
> in the board file.
> 
> spl_perform_fixups will be called in the SPL and now sets the correct
> memory size in the device tree of U-Boot by calling fixup_memory_node.
> U-Boot will then adjust the memory sizes of Linux during bootm/booti in
> fdt_fixup_memory_banks. This chain ensures that U-Boot and Linux only
> use RAM that is actually available.
> 
> Fixes: 3f866c47b582 ("board: verdin-am62: add dram_init_banksize")
> Fixes: bc07851897bd ("board: ti: Pull redundant DDR functions to a common location and Fixup DDR size when ECC is enabled")
> Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>

Acked-by: Francesco Dolcini <francesco.dolcini@toradex.com>

Tom: this is needed in master, this fixes a regression, preventing Linux
to boot, in v2025.04.

Thanks
Francesco


  reply	other threads:[~2025-03-04  7:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-03 18:16 [PATCH v1] board: verdin-am62: fix missing memory fixup call Stefan Eichenberger
2025-03-04  7:09 ` Francesco Dolcini [this message]
2025-03-04 16:57 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250304070955.GA6339@francesco-nb \
    --to=francesco@dolcini.it \
    --cc=eichest@gmail.com \
    --cc=emanuele.ghidoli@toradex.com \
    --cc=francesco.dolcini@toradex.com \
    --cc=n-francis@ti.com \
    --cc=s-k6@ti.com \
    --cc=stefan.eichenberger@toradex.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=w.egorov@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox