Re: 回复: [PATCH v7 10/19] imx9: scmi: add i.MX95 SoC and clock related code

Marek Vasut
2025-03-22T02:49:54Z

On 3/21/25 8:17 AM, Alice Guo (OSS) wrote:

[...]

>>> diff --git a/arch/arm/mach-imx/imx9/scmi/clock.c
>> b/arch/arm/mach-imx/imx9/scmi/clock.c
>>> new file mode 100644
>>> index 0000000000..9ebd380976
>>> --- /dev/null
>>> +++ b/arch/arm/mach-imx/imx9/scmi/clock.c
>>> @@ -0,0 +1,105 @@
>>> +// SPDX-License-Identifier: GPL-2.0+
>>> +/*
>>> + * Copyright 2025 NXP
>>> + */
>>> +
>>> +#include <asm/arch/clock.h>
>>> +#include <dm/uclass.h>
>>> +#include <scmi_agent.h>
>>> +#include "../../../../../dts/upstream/src/arm64/freescale/imx95-clock.h"
>>>
>> "Interesting" include path...
>> Shouldn't this file be located under dts/upstream/include/dt-bindings/ like all the
>> other imx*-clock.h files?
>> Then the file should be picked up via
>> #include <dt-bindings/imx95-clock.h>
>
> Hi,
>
> imx95-clock.h is not in this directory dts/upstream/include/dt-bindings/.
I noticed this odd location of imx95-clock.h in Linux too , it is not in
the include/dt-bindings directory . Why is that ?