Re: [PATCH 1/2] imx8qxp: Do not use CONFIG_XPL_BUILD in device tree

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1306 bytes --]

On Mon, Mar 17, 2025 at 12:10:04PM +0100, Quentin Schulz wrote:
> Hi Fabio,
> 
> On 3/15/25 12:58 PM, Fabio Estevam wrote:
> > Hi Hendrik,
> > 
> > On Fri, Mar 14, 2025 at 5:09 PM Hendrik Donner <hd@os-cillation.de> wrote:
> > > 
> > > In c9713c155127 the device tree was moved
> > > from CONFIG_SPL to CONFIG_SPL_BUILD and later to CONFIG_XPL_BUILD, but
> > > the CONFIG_xPL_BUILD defines are never set for device trees, breaking
> > > the build. Move the guards back to CONFIG_SPL.
> > 
> > Please provide details about the "breaking the build". Which target
> 
> The nodes will simply never be added, because CONFIG_XPL_BUILD (or
> CONFIG_SPL_BUILD) simply aren't passed to dtc.
> 
> So essentially, this is equivalent to dead/noop code.
> 
> > fails to build currently?
> > 
> > After applying this series, the previous build failures return:
> > 
> 
> Yes, it was never fixed, just silenced by never building it.
> 
> See https://lore.kernel.org/u-boot/2849ff05-ef67-4471-aece-422daa57040f@cherry.de/

It sounds to me like imx8/9 and faking external blobs isn't being
handled correctly at this time. Along with needing to make use of
making use of CONFIG_BUILD_TARGET so that "make all" will build the
right binary (when the right external blobs exist).

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]