Re: [PATCH 1/3] mux: Kconfig: Add Kconfig options for MUX_MMIO

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1570 bytes --]

On Thu, Mar 20, 2025 at 12:00:02PM +0530, Anurag Dutta wrote:
> Add Kconfig options for MUX_MMIO so that it can be enabled
> in SPL stage.
> 
> Signed-off-by: Anurag Dutta <a-dutta@ti.com>
> ---
>  drivers/mux/Kconfig | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/mux/Kconfig b/drivers/mux/Kconfig
> index f15ee4f833f..2b95eb02177 100644
> --- a/drivers/mux/Kconfig
> +++ b/drivers/mux/Kconfig
> @@ -10,6 +10,16 @@ config MULTIPLEXER
>  
>  if MULTIPLEXER
>  
> +config SPL_MUX_MMIO
> +	bool "MMIO register bitfield-controlled Multiplexer"
> +        depends on MULTIPLEXER && SYSCON
> +        help
> +          MMIO register bitfield-controlled Multiplexer controller.
> +
> +          The driver builds multiplexer controllers for bitfields in a syscon
> +          register. For N bit wide bitfields, there will be 2^N possible
> +          multiplexer states.
> +
>  config MUX_MMIO
>  	bool "MMIO register bitfield-controlled Multiplexer"
>  	depends on MULTIPLEXER && SYSCON

First, "config SPL_FOO" should follow "config FOO". Second, "config
MUX_MMIO" is written wrong because doing:

if MULTIPLEXER

config MUX_MMIO
	bool "..."
	depends on MULTIPLEXER

endif

Is redundant. Lets fix that and then not repeat it when adding
SPL_MUX_MMIO.

Next, it should be "default y if MUX_MMIO" _unless_ it's really not
going to be needed in most cases, and then yes, what you did is right.

Finally, SPL_MUX_MMIO should depend on SPL_SYSCON as that symbol does
exist.

Thanks.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]