Re: [PATCH] toradex: apalis-imx6: Fix build failure when CONFIG_VIDEO_IPUV3 is enabled

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1121 bytes --]

On Sun, Mar 30, 2025 at 08:56:32PM +0200, Francesco Dolcini wrote:
> On Fri, Mar 28, 2025 at 10:05:57AM -0600, Tom Rini wrote:
> > On Fri, Mar 28, 2025 at 11:20:40AM +0100, rafael@beims.me wrote:
> > 
> > > From: Rafael Beims <rafael.beims@toradex.com>
> > > 
> > > If CONFIG_VIDEO_IPUV3 is enabled without also having CONFIG_IMX_HDMI
> > > enabled, the build fails for the Apalis iMX6 board.
> > > 
> > > Fixes: 592f4aed6db7 ("arm: imx: initial support for apalis imx6")
> > > Signed-off-by: Rafael Beims <rafael.beims@toradex.com>
> > > ---
> > >  board/toradex/apalis_imx6/apalis_imx6.c | 14 ++++++++++++--
> > >  1 file changed, 12 insertions(+), 2 deletions(-)
> > 
> > Is there a reason why this requirement isn't enforced at the Kconfig
> > level? In other words is (CONFIG_VIDEO_IPUV3=y && CONFIG_IMX_HDMI=n) an
> > otherwise useful and valid configuration?
> 
> I would say no. You can have the display output over DPI or LVDS, with
> HDMI non being required at all.

And so yes, it's a useful and valid configuration. OK, thanks.

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]