From: Tom Rini <trini@konsulko.com>
To: Simon Glass <sjg@chromium.org>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
Guillaume La Roque <glaroque@baylibre.com>,
Igor Opaniuk <igor.opaniuk@gmail.com>,
Mattijs Korpershoek <mkorpershoek@baylibre.com>,
Maximilian Brune <maximilian.brune@9elements.com>,
Moritz Fischer <moritzf@google.com>
Subject: Re: [PATCH 07/17] bootstd: Fully complete iteration of a uclass
Date: Mon, 31 Mar 2025 11:41:17 -0600 [thread overview]
Message-ID: <20250331174117.GH93000@bill-the-cat> (raw)
In-Reply-To: <20250319143820.2385092-8-sjg@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 828 bytes --]
On Wed, Mar 19, 2025 at 03:38:01PM +0100, Simon Glass wrote:
> When trying all bootdevs in a uclass, the method flags are not preserved
> in the iterator.
>
> This has no impact on the first bootdev, since that is the one which
> sets the flags. For the next one, iter_inc() is used and it finds the
> next bootdev. However it sets the method_flags to 0
>
> The result is that the third scan is conducted without the required
> BOOTFLOW_METHF_SINGLE_UCLASS flag, so iteration procees to the next
> label. This can miss bootdevs if there three or more USB-storage
> devices, for example.
>
> Fix this by keeping the method flags around in this case.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
This seems like a real bugfix and a fixes tag would help make it clear
what it applies to.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2025-03-31 17:41 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 14:37 [PATCH 00/17] bootstd: Useability improvements Simon Glass
2025-03-19 14:37 ` [PATCH 01/17] fs: boot: Update fs_read_alloc() to use abuf Simon Glass
2025-03-31 17:42 ` Tom Rini
2025-04-01 15:46 ` Simon Glass
2025-04-01 16:50 ` Tom Rini
2025-05-01 12:07 ` Simon Glass
2025-03-19 14:37 ` [PATCH 02/17] fs: boot: Update fs_load_alloc() " Simon Glass
2025-03-19 14:37 ` [PATCH 03/17] fs: boot: Update bootmeth_alloc_other() " Simon Glass
2025-03-19 14:37 ` [PATCH 04/17] bootstd: Add more debugging to bootmeth_efi Simon Glass
2025-03-19 14:37 ` [PATCH 05/17] bootstd: Add more debugging to bootmeth_extlinux Simon Glass
2025-03-19 14:38 ` [PATCH 06/17] bootstd: Try all bootmeths on the final partition Simon Glass
2025-03-31 17:41 ` Tom Rini
2025-03-19 14:38 ` [PATCH 07/17] bootstd: Fully complete iteration of a uclass Simon Glass
2025-03-31 17:41 ` Tom Rini [this message]
2025-03-19 14:38 ` [PATCH 08/17] test/py: Split out core of Fedora image into a new function Simon Glass
2025-03-19 14:38 ` [PATCH 09/17] test/py: Add a test image for Ubuntu Simon Glass
2025-03-19 14:52 ` Tom Rini
2025-03-19 15:04 ` Simon Glass
2025-03-19 15:35 ` Tom Rini
2025-03-20 3:41 ` Simon Glass
2025-03-30 14:45 ` Tom Rini
2025-04-01 15:49 ` Simon Glass
2025-04-01 16:48 ` Tom Rini
2025-04-01 17:55 ` Simon Glass
2025-04-11 19:13 ` Tom Rini
2025-04-12 12:45 ` Simon Glass
2025-04-12 18:41 ` Tom Rini
2025-03-19 14:38 ` [PATCH 10/17] usb: Use more useful names for block devices Simon Glass
2025-03-19 14:38 ` [PATCH 11/17] sandbox: Use a unique name for each USB controller Simon Glass
2025-03-19 14:38 ` [PATCH 12/17] bootstd: Tweak scanning with labels Simon Glass
2025-03-19 14:38 ` [PATCH 13/17] bootstd: Tidy up a nested CONFIG_IS_ENABLED(BOOTSTD) Simon Glass
2025-03-19 14:38 ` [PATCH 14/17] bootstd: Provide a command to select the bootdev order Simon Glass
2025-03-19 14:38 ` [PATCH 15/17] bootstd: Correct the comment for bootmeth_set_order() Simon Glass
2025-03-19 14:38 ` [PATCH 16/17] bootstd: Expand debugging in bootdev_find_in_blk() Simon Glass
2025-03-19 14:38 ` [PATCH 17/17] bootstd: Mention FS state in bootmeth_read_bootflow() Simon Glass
2025-03-31 17:40 ` [PATCH 00/17] bootstd: Useability improvements Tom Rini
2025-04-01 15:53 ` Simon Glass
2025-04-01 17:01 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250331174117.GH93000@bill-the-cat \
--to=trini@konsulko.com \
--cc=glaroque@baylibre.com \
--cc=igor.opaniuk@gmail.com \
--cc=maximilian.brune@9elements.com \
--cc=mkorpershoek@baylibre.com \
--cc=moritzf@google.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox