From: Tom Rini <trini@konsulko.com>
To: Anshul Dalal <anshuld@ti.com>
Cc: u-boot@lists.denx.de, vigneshr@ti.com
Subject: Re: [PATCH v5] spl: remove usage of CMD_BOOT[IZ] from image parsing
Date: Mon, 31 Mar 2025 17:03:01 -0600 [thread overview]
Message-ID: <20250331230301.GA30101@bill-the-cat> (raw)
In-Reply-To: <20250314035505.4029331-1-anshuld@ti.com>
[-- Attachment #1: Type: text/plain, Size: 761 bytes --]
On Fri, Mar 14, 2025 at 09:25:04AM +0530, Anshul Dalal wrote:
> Using CMD_* configs from spl doesn't make logical sense. Therefore this
> patch replaces the checks for CMD_BOOT[IZ] with newly added configs
> SPL_HAS_BOOT[IZ].
>
> SPL_HAS_BOOTZ is enabled by default for 32-bit ARM systems and
> SPL_HAS_BOOTI is enabled by default for 64-bit ARM and RISCV. This
> ensures configs relying on CMD_BOOT[IZ] in falcon boot still work.
>
> Signed-off-by: Anshul Dalal <anshuld@ti.com>
OK, so this needs to be introducing some library symbol which then both
CMD_BOOTx and SPL_...something select. What we have here introduces
failure to build on some imx8 platforms such as
mx8mp_evk and then size growth on others such as imx28_xea.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2025-03-31 23:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-14 3:55 [PATCH v5] spl: remove usage of CMD_BOOT[IZ] from image parsing Anshul Dalal
2025-03-14 14:54 ` Tom Rini
2025-03-31 23:03 ` Tom Rini [this message]
2025-04-02 10:30 ` Anshul Dalal
2025-04-02 14:00 ` Tom Rini
2025-04-03 22:07 ` Anshul Dalal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250331230301.GA30101@bill-the-cat \
--to=trini@konsulko.com \
--cc=anshuld@ti.com \
--cc=u-boot@lists.denx.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox