From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13542C36010 for ; Tue, 1 Apr 2025 16:49:06 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 88DE980FDA; Tue, 1 Apr 2025 18:49:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="EB+Vban9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E574281703; Tue, 1 Apr 2025 18:49:03 +0200 (CEST) Received: from mail-ot1-x329.google.com (mail-ot1-x329.google.com [IPv6:2607:f8b0:4864:20::329]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 80608801BE for ; Tue, 1 Apr 2025 18:49:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-ot1-x329.google.com with SMTP id 46e09a7af769-72bb97260ceso1417747a34.1 for ; Tue, 01 Apr 2025 09:49:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1743526140; x=1744130940; darn=lists.denx.de; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=FYuY3jA6zogwcJOvr7uDHag8HtjI6sevSx1JeEkRxt4=; b=EB+Vban93a8TEJzsEFZgedfduJCThi7VDWRPdUTF8hWyx5tfIDWXwSue4NrkAmP+4b /ENir4dZlG/4yrECuiaU4VXCMrRsuvwtFXTfzpbpTX+ufeGEr61QJFWM5fPdtJED6E5Z FSKHmxT2ezV/2gg/z/2t53rnBO8FzWhYDMVNI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743526140; x=1744130940; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FYuY3jA6zogwcJOvr7uDHag8HtjI6sevSx1JeEkRxt4=; b=J7b5JeqGiZiql3PXrE2JLE/hkLQcPi/7b/oI+cFzosmwMRyk7EUsJZnfcQMMsX5Q6S LArswSRGw1mOvX1VFwiHHYaIxATOEfmGNz87mozh43qMc4dJunf28QSHiB8KUJjKYQGR ilz8hLswkoTJp2Qa2oGZeiybiYohPTY8prMCpnQC5/uPNtYUD1biGAkgYj1x0MOtwaBc RNV81svqZPBtHJWgDBTqBhNJQhPFCzzTHyFogpMI+w40LXyQCukzpfgJVNmdZt+CKhHB snJAQF8hv683jRDo9P58ywzHGmuYttdcuMI5Y8knZrYUzRSVvQpz/HkmVzopQcxqw1IM gRRA== X-Gm-Message-State: AOJu0YygbSw2qJUM9JDqFlCbyilnKLzPwRUL07CzezNHN8+Odt0qPnND y/5N7DStfOROdKOGzzfvU0bj69ri6CdT5H5a8hcAZONPXkCAegQMSWoyWuw8Afs= X-Gm-Gg: ASbGncuISmJB3tSXYI3Crg5KU4RALj8ahMcqL322pnX8OjfEvGOURbIzlDSYlPH1FCr mYHH+ol2dfPLPxt4auaqfdUmjU5eXM1qDPAIJnjQ98vlKrOJwTuy+PMGKrzlYkO768bot8NeKo9 xZ1jZwWToqQulnB13HVIJucDoXw1w3spNsdPgfSs6ZMlRqyKBWuTiQpLYJjZcSqw5HG3ZVcwZpe cY9nhci23c5NeMb0wap9nD/eS2ZgcJnGWSONdnDzFWjczc6263zbHly+6eg9XWKH5stdBIMeqTN xyTibAP/nX/EsmXi/Pt5I0QpYIqzc+f7qLXwoysGO0mZlx8o9FzdHREPIzqlVuDASRhKFsAdCsM q2Ztlag== X-Google-Smtp-Source: AGHT+IFzlyNHEmh84uFQJHVgRMYV0tl+ND78gknJQgdgl34SDcclZ/NiAzRUrkIgGKChwPx2modiNQ== X-Received: by 2002:a05:6830:4195:b0:72c:3235:3b99 with SMTP id 46e09a7af769-72c63816ed4mr7248979a34.19.1743526140181; Tue, 01 Apr 2025 09:49:00 -0700 (PDT) Received: from bill-the-cat (fixed-187-190-205-42.totalplay.net. [187.190.205.42]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-72c580bb551sm1933798a34.20.2025.04.01.09.48.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Apr 2025 09:48:59 -0700 (PDT) Date: Tue, 1 Apr 2025 10:48:56 -0600 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , Caleb Connolly , Christian Marangi , Guillaume La Roque , Heinrich Schuchardt , Ilias Apalodimas , Jerome Forissier , Julien Masson , Julius Lehmann , Marek Vasut , Mattijs Korpershoek , Patrick Rudolph , Richard Weinberger , Stephen Warren , Stephen Warren , Sughosh Ganu Subject: Re: [PATCH 09/17] test/py: Add a test image for Ubuntu Message-ID: <20250401164856.GH5495@bill-the-cat> References: <20250319143820.2385092-1-sjg@chromium.org> <20250319143820.2385092-10-sjg@chromium.org> <20250319145218.GG2640854@bill-the-cat> <20250319153510.GJ2640854@bill-the-cat> <20250330144542.GQ93000@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="CdeqISXwe5cbrSkD" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --CdeqISXwe5cbrSkD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 02, 2025 at 04:49:18AM +1300, Simon Glass wrote: > Hi Tom, >=20 > On Mon, 31 Mar 2025 at 03:45, Tom Rini wrote: > > > > On Thu, Mar 20, 2025 at 03:41:33AM +0000, Simon Glass wrote: > > > Hi Tom, > > > > > > On Wed, 19 Mar 2025 at 16:35, Tom Rini wrote: > > > > > > > > On Wed, Mar 19, 2025 at 03:04:28PM +0000, Simon Glass wrote: > > > > > Hi Tom, > > > > > > > > > > On Wed, 19 Mar 2025 at 15:52, Tom Rini wrote: > > > > > > > > > > > > On Wed, Mar 19, 2025 at 03:38:03PM +0100, Simon Glass wrote: > > > > > > > > > > > > > Add an extlinux image that contains a few Ubuntu entries. > > > > > > > > > > > > > > Increase the number of sandbox-USB-hub ports to permit this. > > > > > > > > > > > > > > Signed-off-by: Simon Glass > > > > > > > > > > > > I don't understand what this test adds. In neither the current = Fedora > > > > > > test nor in this new test are we actually booting something, we= 're just > > > > > > taking a sample extlinux.conf and making sure it doesn't fail. = Is it > > > > > > that we're testing in a useful fashion now having two labels? > > > > > > > > > > I didn't think so either, which is why I never did this before. B= ut it > > > > > turns out that there were some bugs, too. > > > > > > > > I don't understand you, sorry. You don't think so either to what? > > > > > > I didn't think we needed two extlinux examples on different boot > > > devices, but we do. > > > > I'm not sure it's particularly clear what you're doing here then, or > > why, but I'll find some time to read it all more deeply. >=20 > OK. This test case is how I found the bugs/problems in bootstd that > are fixed in this series. It should be (a) better explained and likely (b) instead of dropping in a seemingly verbatim installed file a specially crafted bit of content. We aren't testing "Ubuntu". We are testing multiple labels. > > > > > > We should probably be clear about what we're doing in the tests= and > > > > > > instead of adding seemingly arbitrary distributions add an extl= inux test > > > > > > and testcases. > > > > > > > > > > This is not actually a test case. It is simply creating a new ima= ge. > > > > > The test cases are in the other patches, so please take a look th= ere. > > > > > > > > Nothing in this series quickly reads as adding tests and fixing pro= blems > > > > with extlinux parsing, it's all bootmeth stuff? > > > > > > It isn't about the actual parsing of the .conf file, although I would > > > like to add tests there as we have none apart from what I have added > > > in my PXE series. It's more about having multiple devices with > > > bootable OSes on them. This series tidies up and fixes this. We need > > > to have an image available on more than one device to spot these > > > problems. > > > > And the existing tests for pxelinux that we have in mainline already, > > don't forget those. >=20 > Yes. But those tests actually don't use bootstd, do they? No, they're testing pxelinux, the thing you said we don't have any tests for. > > > Currently we have two accessible to sandbox, one extlinux and one > > > EFI*. I decided to add a third, using extlinux. > > > > > > Again, this is not a test case, but provides an image for the test > > > cases in this series. > > > > Adding mocked up things for use in sandbox is adding test cases. >=20 > One is a test image for use by tests; the other is a test. Perhaps you > are just saying that there is no point in having one without the > other? Otherwise, I'm not sure what to do with this feedback. Maybe I clarified better above now. You're not testing Ubuntu (or Fedora or Armbian or ...) you're seeing if various pxelinux files parse correctly. Making the tests be clearer about what's being tested is what's missing at least in part. --=20 Tom --CdeqISXwe5cbrSkD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmfsGPgACgkQFHw5/5Y0 tyy/owv/WX+yvQNYZXT4jxJlFPCwGRkrqUx82DRJmyeJEs0MmK37jI3YhtnUY0db x0OI7W0DK5m285/Y/oSwbDL8qZgSQZERjNnH+iet/CZDXVXU7QTikFew0VR9IJyD 7maEle/jliQikeVP+HZcnLoXiOuxRJPTwqI6djTfixbgio80JwzTa/LD3SkpAP68 9C3ejB+A+mwUeIW2cBSo758l2WArHxRiizSFNooeZzG45E1qBR/PzdECPAqunjwe jsUOdI4mMmydt01m2tl00gfznadtAPeXpEp06ZQ324UZfmnnPA+sPSiA3dJKjdpc XQsgr1KxLiY3dOluCAq4jaV6aBQrkxxDCWOMIF+j4CHjSedYsjoOTBoi2nwYvLGK 2nBdknM2wEYSAVDxK2uM5tKDOP8jzjVII5HSgV/toClYeaIbvjjMwXJwz07WwwZy 7/Z7R3d6X1oqnbx8vKys9cEZhKgdc777MtonAkk+CdX9fOMMa2hAy04ZDI8gtoPx XBWecFm4 =zTQi -----END PGP SIGNATURE----- --CdeqISXwe5cbrSkD--