From: Fabio Estevam <festevam@gmail.com>
To: eugen.hristev@linaro.org
Cc: u-boot@lists.denx.de, trini@konsulko.com,
Fabio Estevam <festevam@denx.de>
Subject: [PATCH v2 1/2] board: atmel: sama5d2_wlsom1_ek: Fix spurious serial output
Date: Fri, 4 Apr 2025 08:39:18 -0300 [thread overview]
Message-ID: <20250404113919.3860489-1-festevam@gmail.com> (raw)
From: Fabio Estevam <festevam@denx.de>
Currently, there are always some spurious characters showing up
right before SPL banner is shown:
RomBOOT
���=������
U-Boot SPL 2025.04-rc5-00023-g9ed4e2c45f25 (Apr 03 2025 - 23:23:17 -0300)
Trying to boot from MMC1
<debug_uart>
...
The reason for the spurious characters is that the UART0 clock is
being enabled too early, prior to adjusting its correct frequency.
Fix the problem by removing the early UART0 clock enablement in C code.
SPL DM code will adjust the correct UART0 clock frequency and then enable
it at the appropriate time.
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Changes since v1:
- Make the minimal change to fix the spurious characters. Improve
the explanation in the commit log.
board/atmel/sama5d27_wlsom1_ek/sama5d27_wlsom1_ek.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/board/atmel/sama5d27_wlsom1_ek/sama5d27_wlsom1_ek.c b/board/atmel/sama5d27_wlsom1_ek/sama5d27_wlsom1_ek.c
index 04de1257eca0..ff5e51ee3926 100644
--- a/board/atmel/sama5d27_wlsom1_ek/sama5d27_wlsom1_ek.c
+++ b/board/atmel/sama5d27_wlsom1_ek/sama5d27_wlsom1_ek.c
@@ -45,8 +45,6 @@ static void board_uart0_hw_init(void)
{
atmel_pio4_set_c_periph(AT91_PIO_PORTB, 26, ATMEL_PIO_PUEN_MASK); /* URXD0 */
atmel_pio4_set_c_periph(AT91_PIO_PORTB, 27, 0); /* UTXD0 */
-
- at91_periph_clk_enable(ATMEL_ID_UART0);
}
void board_debug_uart_init(void)
--
2.34.1
next reply other threads:[~2025-04-04 11:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-04 11:39 Fabio Estevam [this message]
2025-04-04 11:39 ` [PATCH v2 2/2] board: atmel: sama5d2_wlsom1_ek: Remove UART pinctrl initialization Fabio Estevam
2025-04-07 6:39 ` [PATCH v2 1/2] board: atmel: sama5d2_wlsom1_ek: Fix spurious serial output Eugen Hristev
2025-04-07 23:52 ` Fabio Estevam
2025-04-08 7:55 ` Eugen Hristev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250404113919.3860489-1-festevam@gmail.com \
--to=festevam@gmail.com \
--cc=eugen.hristev@linaro.org \
--cc=festevam@denx.de \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox