Re: [PATCH v2 0/4] Add support for RAM boot from maskrom mode

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1804 bytes --]

On Sat, Apr 05, 2025 at 06:02:37PM +0200, Mark Kettenis wrote:
> > From: Jonas Karlman <jonas@kwiboo.se>
> > Date: Sat,  5 Apr 2025 15:38:20 +0000
> > 
> > The BootROM in Rockchip SoCs will enter maskrom mode when boot firmware
> > cannot be found in nand/spi/mmc storage.
> > 
> > In maskrom mode the USB OTG port can accept one of two custom commands.
> > 
> > Initially a 0x471 command to load TPL into SRAM. After TPL has been
> > executed and it has returned back-to-BROM, a 0x472 command to load SPL
> > into start of DRAM.
> > 
> > This series adds two binman images that can be used to RAM boot from
> > maskrom mode:
> > - u-boot-rockchip-usb471.bin that contains TPL to init DRAM.
> > - u-boot-rockchip-usb472.bin that contains SPL and the normal FIT
> >   payload with i.e. U-Boot proper, TF-A and FDT.
> > 
> > These images can be used with rkbin tools/boot_merger to create a loader
> > image to be used with rkdeveloptool or rockusb tools, e.g.:
> > 
> >   Create loader image:
> >     $ ../rkbin/tools/boot_merger ./RK3588MINIALL.ini
> > 
> >   Boot from maskrom:
> >     $ rkdeveloptool db u-boot-rockchip-rk3588-loader.bin
> >    or
> >     $ rockusb download-boot u-boot-rockchip-rk3588-loader.bin
> > 
> > Or directly with tools such as rkflashtool or rkusbboot:
> > 
> >   $ rkflashtool l < u-boot-rockchip-usb471.bin
> >   $ rkflashtool L < u-boot-rockchip-usb472.bin
> >  or
> >   $ rkusbboot u-boot-rockchip-usb471.bin u-boot-rockchip-usb472.bin
> 
> Hi Jonas,
> 
> Would be great if you could document this, maybe in
> doc/README.rockchup and/or doc/board/rockchip/rockchip.rst?

I would just note that doc/README.rockchup should have any content not
found under doc/board/rockchip/ migrated there and then removed, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]