From: Daniel Schultz <d.schultz@phytec.de>
To: <trini@konsulko.com>, <n-francis@ti.com>, <u-kumar1@ti.com>,
<bb@ti.com>, <afd@ti.com>, <u-boot@lists.denx.de>
Cc: <upstream@lists.phytec.de>, <w.egorov@phytec.de>,
Daniel Schultz <d.schultz@phytec.de>
Subject: [PATCH] mach-k3: common_fdt: Fix Label Issue
Date: Sun, 6 Apr 2025 23:07:11 -0700 [thread overview]
Message-ID: <20250407060711.3160366-1-d.schultz@phytec.de> (raw)
Labels are not allowed before declarations. Add a semicolon after the
label to introduce an empty statement. This will fix following error:
arch/arm/mach-k3/common_fdt.c: In function 'fdt_fixup_reserved':
arch/arm/mach-k3/common_fdt.c:156:2: error: a label can only be part of a statement and a declaration is not a statement
156 | struct fdt_memory carveout = {
| ^~~~~~
make[1]: *** [scripts/Makefile.build:256: arch/arm/mach-k3/common_fdt.o] Error 1
make: *** [Makefile:1919: arch/arm/mach-k3] Error 2
Fixes: 096aa229a9e ("mach-k3: common_fdt: create a reserved memory node")
Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
---
I'm open to other suggestions! This is just the easiest way to fix this
compile error. BTW, master is fine since 096aa229a9e is only on next.
arch/arm/mach-k3/common_fdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-k3/common_fdt.c b/arch/arm/mach-k3/common_fdt.c
index 361b0c0b31b..7178918a12c 100644
--- a/arch/arm/mach-k3/common_fdt.c
+++ b/arch/arm/mach-k3/common_fdt.c
@@ -152,7 +152,7 @@ int fdt_fixup_reserved(void *blob, const char *name,
}
}
-add_carveout:
+add_carveout: ;
struct fdt_memory carveout = {
.start = new_address,
.end = new_address + new_size - 1,
--
2.25.1
next reply other threads:[~2025-04-07 6:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 6:07 Daniel Schultz [this message]
2025-04-07 8:21 ` [PATCH] mach-k3: common_fdt: Fix Label Issue Kumar, Udit
2025-04-07 8:26 ` Neha Malcom Francis
2025-04-09 7:14 ` Daniel Schultz
2025-04-07 20:15 ` Bryan Brattlof
2025-04-14 22:59 ` Tom Rini
2025-04-16 5:18 ` Daniel Schultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250407060711.3160366-1-d.schultz@phytec.de \
--to=d.schultz@phytec.de \
--cc=afd@ti.com \
--cc=bb@ti.com \
--cc=n-francis@ti.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=u-kumar1@ti.com \
--cc=upstream@lists.phytec.de \
--cc=w.egorov@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox