From: Sumit Garg <sumit.garg@kernel.org>
To: u-boot@lists.denx.de, u-boot-qcom@groups.io
Cc: caleb.connolly@linaro.org, neil.armstrong@linaro.org,
trini@konsulko.com, alexeymin@postmarketos.org,
Sumit Garg <sumit.garg@oss.qualcomm.com>
Subject: [PATCH v2 2/2] phy: phy-qcom-qusb2: Fix USB PHY power on sequence
Date: Thu, 10 Apr 2025 13:30:27 +0530 [thread overview]
Message-ID: <20250410080027.208674-3-sumit.garg@kernel.org> (raw)
In-Reply-To: <20250410080027.208674-1-sumit.garg@kernel.org>
From: Sumit Garg <sumit.garg@oss.qualcomm.com>
Recent addition of support for SDM660 inadvertently broke USB PHY power
on sequence on RB1/RB2 and others with following error:
starting USB...
Bus usb@4e00000: QUSB2PHY pll lock failed: status reg = 0
qcom-qusb2-phy phy@1613000: PHY: Failed to power on phy@1613000: -16.
Can't power on PHY0
probe failed, error -16
No USB controllers found
The root cause was the addition of flag se_clk_scheme_default which was
configured correctly for SDM660 but incorrect for all other supported
SoC. Fix that by properly assignment as per upstream Linux driver.
Fixes: 475497dc3c15 ("phy: Add SDM660 support to Qualcomm QUSB2 phy")
Signed-off-by: Sumit Garg <sumit.garg@oss.qualcomm.com>
---
drivers/phy/qcom/phy-qcom-qusb2.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/phy/qcom/phy-qcom-qusb2.c b/drivers/phy/qcom/phy-qcom-qusb2.c
index cabd05bf5a6..d98f6108e69 100644
--- a/drivers/phy/qcom/phy-qcom-qusb2.c
+++ b/drivers/phy/qcom/phy-qcom-qusb2.c
@@ -230,6 +230,7 @@ static const struct qusb2_phy_cfg sm6115_phy_cfg = {
.regs = sm6115_regs_layout,
.has_pll_test = true,
+ .se_clk_scheme_default = true,
.disable_ctrl = (CLAMP_N_EN | FREEZIO_N | POWER_DOWN),
.mask_core_ready = PLL_LOCKED,
.autoresume_en = BIT(3),
@@ -256,6 +257,7 @@ static const struct qusb2_phy_cfg qusb2_v2_phy_cfg = {
POWER_DOWN),
.mask_core_ready = CORE_READY_STATUS,
.has_pll_override = true,
+ .se_clk_scheme_default = true,
.autoresume_en = BIT(0),
.update_tune1_with_efuse = true,
};
--
2.43.0
next prev parent reply other threads:[~2025-04-10 8:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 8:00 [PATCH v2 0/2] RB1 fixes Sumit Garg
2025-04-10 8:00 ` [PATCH v2 1/2] qcom_defconfig: Disable MMC HS200 mode support Sumit Garg
2025-04-10 8:56 ` neil.armstrong
2025-04-10 8:00 ` Sumit Garg [this message]
2025-04-10 8:56 ` [PATCH v2 2/2] phy: phy-qcom-qusb2: Fix USB PHY power on sequence neil.armstrong
2025-04-10 8:56 ` neil.armstrong
2025-04-10 9:51 ` Caleb Connolly
2025-04-10 9:54 ` [PATCH v2 0/2] RB1 fixes Caleb Connolly
2025-04-11 13:36 ` Caleb Connolly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250410080027.208674-3-sumit.garg@kernel.org \
--to=sumit.garg@kernel.org \
--cc=alexeymin@postmarketos.org \
--cc=caleb.connolly@linaro.org \
--cc=neil.armstrong@linaro.org \
--cc=sumit.garg@oss.qualcomm.com \
--cc=trini@konsulko.com \
--cc=u-boot-qcom@groups.io \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox