From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4F4BC3601E for ; Thu, 10 Apr 2025 09:23:28 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id ED15B83B3C; Thu, 10 Apr 2025 11:23:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id A380483B47; Thu, 10 Apr 2025 11:23:25 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id 421D883B32 for ; Thu, 10 Apr 2025 11:23:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7BB2D106F; Thu, 10 Apr 2025 02:23:22 -0700 (PDT) Received: from donnerap.manchester.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E45D43F6A8; Thu, 10 Apr 2025 02:23:17 -0700 (PDT) Date: Thu, 10 Apr 2025 10:23:15 +0100 From: Andre Przywara To: Jernej =?UTF-8?B?xaBrcmFiZWM=?= Cc: Jagan Teki , Samuel Holland , Tom Rini , Simon Glass , Hans de Goede , Olliver Schinagl , Iain Paton , Marcus Cooper , Stefan Mavrodiev , Paul Kocialkowski , Chen-Yu Tsai , Maxime Ripard , Ian Campbell , Adam Sampson , Zoltan Herpai , Siarhei Siamashka , VishnuPatekar , Rask Ingemann Lambertsen , Aleksei Mamlin , Peter Korsgaard , Michal Suchanek , Icenowy Zheng , Stefan Roese , Phil Han , Quentin Schulz , Jonas Smedegaard , Jaehoon Chung , Heiko Schocher , u-boot@lists.denx.de, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v2 1/8] power: regulator: Add a driver for the AXP PMIC drivevbus Message-ID: <20250410102315.6e080dbd@donnerap.manchester.arm.com> In-Reply-To: <4971028.GXAFRqVoOG@jernej-laptop> References: <20250409002036.12212-1-andre.przywara@arm.com> <20250409002036.12212-2-andre.przywara@arm.com> <4971028.GXAFRqVoOG@jernej-laptop> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Thu, 10 Apr 2025 09:04:35 +0200 Jernej =C5=A0krabec wrote: > Dne sreda, 9. april 2025 ob 02:20:29 Srednjeevropski poletni =C4=8Das je = Andre Przywara napisal(a): > > From: Samuel Holland > >=20 > > AXP PMICs have a pin which can either report the USB VBUS state, or > > driving a regulator that supplies USB VBUS. Add a regulator driver for > > controlling this pin. The selection between input and output is done via > > the x-powers,drive-vbus-en pin on the PMIC (parent) node. > >=20 > > Signed-off-by: Samuel Holland > > Signed-off-by: Andre Przywara =20 >=20 > Would it be less error prone to auto enable Kconfig option when compatible > AXP device is enabled? That way defconfigs could be smaller. Driver is pr= etty > small anyway. Yes, but the whole PMIC config is quite a mess at the moment. Those AXPxxx_POWER symbols are really for the SPL part only, and do nothing in U-Boot proper, where everything is guarded by CONFIG_REGULATOR_AXP and properly detected at runtime through the DT. I tried to enable this driver for all 64-bit boards, to be able to drop the TF-A code, but ran into problems with the H616 RSB boards, because of this overlap and this "PMIC bus" feature. So I have patches to enable this more universally, and will look at this in the next days and weeks, but first wanted to get the non-controversial parts in, like the driver itself. > In any case: > Reviewed-by: Jernej Skrabec Many thanks for that! Cheers, Andre >=20 > Best regards, > Jernej >=20 >=20