Re: [PATCH 5/7] binman: Workaround lz4 cli padding in test cases

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1238 bytes --]

On Thu, Apr 10, 2025 at 08:53:14AM -0600, Simon Glass wrote:
> Hi Mattijs,
> 
> On Thu, 10 Apr 2025 at 03:27, Mattijs Korpershoek
> <mkorpershoek@kernel.org> wrote:
> >
> > Hi Simon,
> >
> > Thank you for the patch.
> >
> > On mar., mars 04, 2025 at 06:09, Simon Glass <sjg@chromium.org> wrote:
> >
> > > From: Jiaxun Yang <jiaxun.yang@flygoat.com>
> > >
> > > Newer lz4 util is not happy with any padding at end of file,
> > > it would abort with error message like:
> > >
> > > Stream followed by undecodable data at position 43.
> > >
> > > Workaround by skipping testCompUtilPadding test case and manually
> > > strip padding in testCompressSectionSize test case.
> > >
> > > Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> > > Reviewed-by: Simon Glass <sjg@chromium.org>
> > > Signed-off-by: Simon Glass <sjg@chromium.org>
> >
> > Tested that this solves issues when using lz4 1.9.4.
> >
> > This patch solves:
> > https://source.denx.de/u-boot/custodians/u-boot-dm/-/issues/38
> >
> > Tested-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
> >
> 
> Ah, I'd forgotten about this series, as I applied it to my tree a
> while back. I sent a v2 for Tom[1].

For mainline, yes.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]