From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CFD54C36010 for ; Fri, 11 Apr 2025 14:21:31 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5060F840BE; Fri, 11 Apr 2025 16:21:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=dolcini.it Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=dolcini.it header.i=@dolcini.it header.b="Eod/QdIp"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2F352840C1; Fri, 11 Apr 2025 16:21:29 +0200 (CEST) Received: from mail11.truemail.it (mail11.truemail.it [IPv6:2001:4b7e:0:8::81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2039684085 for ; Fri, 11 Apr 2025 16:21:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=dolcini.it Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=francesco@dolcini.it Received: from francesco-nb (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id E7CF31FC42; Fri, 11 Apr 2025 16:21:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dolcini.it; s=default; t=1744381285; bh=ML/Ivn/9ho2tiXQcxsjfLMNMVuNFPS43SIiKcj04mqw=; h=From:To:Subject; b=Eod/QdIpPkbniDJU9PL0khqTXXY4Mn8dnjEKh35HGr6Yu7ihAYoWjYWSDTEXA83Gt KeL8uiztBAoOQ41yb6qtFm8DxNpsBqiWmfexPONuX8EChTo91tsyGgeaT9WV0QvW9f lxfy3eBb8isz3yif7c7ai/O7RlbGaAY4HWv66s4jPhL8qt8/m6bX1ym6v3dI2whVwJ CTpnoVjbIk/fG5WdmB4hVcfV9hhv1PKrmsc4EaCCWP8whv1zMrc9bFEr09OOsqmAkA Cq1Xtv8kAwgyMBbRYGz3RFim0S0j5gbwrHvkk6Anl3ACp9vbqLHxPkBGbV5WI4SKTL icJFbfD68RNNw== Date: Fri, 11 Apr 2025 16:21:23 +0200 From: Francesco Dolcini To: Marek Vasut Cc: Francesco Dolcini , Mattijs Korpershoek , u-boot@lists.denx.de, Alexander Sverdlin , Felipe Balbi , Lukasz Majewski , Neil Armstrong , Thinh Nguyen , Tom Rini Subject: Re: [PATCH] usb: dwc3: gadget: Fix match_ep callback for NXP UUU tool Message-ID: <20250411142123.GC12707@francesco-nb> References: <20250319220805.219001-1-marex@denx.de> <87a59gdofd.fsf@baylibre.com> <20250324080315.GA6932@francesco-nb> <87pli6esx0.fsf@baylibre.com> <42f53c19-de12-45c3-9091-2e6c23d1fcd4@denx.de> <48e57653-d86a-4650-859e-1e77a6c29f4a@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Tue, Apr 08, 2025 at 04:51:22PM +0200, Marek Vasut wrote: > On 4/8/25 11:06 AM, Francesco Dolcini wrote: > > On Mon, Mar 24, 2025 at 03:36:52PM +0100, Marek Vasut wrote: > > > On 3/24/25 3:16 PM, Francesco Dolcini wrote: > > > > On Mon, Mar 24, 2025 at 02:53:23PM +0100, Marek Vasut wrote: > > > > > On 3/24/25 1:30 PM, Francesco Dolcini wrote: > > > > > > On Mon, Mar 24, 2025 at 09:26:03AM +0100, Mattijs Korpershoek wrote: > > > > > > > Hi Francesco, > > > > > > > > > > > > > > On lun., mars 24, 2025 at 09:03, Francesco Dolcini wrote: > > > > > > > > > > > > > > > Hello Mattijs, Marek > > > > > > > > > > > > > > > > On Thu, Mar 20, 2025 at 10:47:02AM +0100, Mattijs Korpershoek wrote: > > > > > > > > > On mer., mars 19, 2025 at 23:07, Marek Vasut wrote: > > > > > > > > > > > > > > > > > > > The UUU tool excepts the interrupt-in endpoint to be ep1in, otherwise > > > > > > > > > > it crashes. This is a result of the previous hard-coded EP setup in > > > > > > > > > > drivers/usb/gadget/epautoconf.c which did special-case EP allocation > > > > > > > > > > for SPL builds, and which was since converted to this callback, but > > > > > > > > > > without the special-case EP allocation in SPL part. > > > > > > > > > > > > > > > > > > > > This reinstates the SPL part in an isolated manner, only for NXP iMX > > > > > > > > > > SoCs, only for SPL builds, and only for the ep1in interrupt-in endpoint. > > > > > > > > > > > > > > > > UUU can (and in our case is) used also on non-NXP i.MX platforms. > > > > > > > > What should we do? > > > > > > > > > > > > > > Do reproduce the problem (UUU tool crashes) on those platforms with > > > > > > > recent U-Boot versions (v2024.10+) ? > > > > > > > > > > > > Not tested, my comment is purely based on the code and the commit message. > > > > > > Older U-Boot versions (up to v2024.04, included) are working fine, with UUU used > > > > > > with TI K3 SoCs (AM69, AM62, AM62P). > > > > > Are you talking about the NXP UUU ? > > > > > > > > yes, it works just fine on not-NXP SoC. > > > Then please test if it still works, and if not, this patch needs to be > > > expanded to cover TI ... or apply unconditionally in SPL (sigh). > > > > I just found the time to check some logs from our CI in which we execute such a > > workflow. We do use UUU only from U-Boot proper, so we are not going to be > > affected by this SPL specific change. > > > > However I found this error in the logs, on both a TI AM62 and an i.MX8MP > > > > ``` > > Starting download of 40524455 bytes > > dwc3-generic-peripheral usb@31000000: request 0000000099f219c0 was not queued to ep1in-bulk > > .......................................................................... > > .......................................................................... > > .......................................................................... > > .......................................................................... > > ............. > > downloading of 40524455 bytes finished > > dwc3-generic-peripheral usb@31000000: request 0000000099f219c0 was not queued to ep1in-bulk > > dwc3-generic-peripheral usb@31000000: request 0000000099f219c0 was not queued to ep1in-bulk > > Starting download of 1675 bytes > > dwc3-generic-peripheral usb@31000000: request 0000000099f219c0 was not queued to ep1in-bulk > > downloading of 1675 bytes finished > > dwc3-generic-peripheral usb@31000000: request 0000000099f219c0 was not queued to ep1in-bulk > > dwc3-generic-peripheral usb@31000000: request 0000000099f219c0 was not queued to ep1in-bulk > > Starting download of 82 bytes > > dwc3-generic-peripheral usb@31000000: request 0000000099f219c0 was not queued to ep1in-bulk > > downloading of 82 bytes finished > > dwc3-generic-peripheral usb@31000000: request 0000000099f219c0 was not queued to ep1in-bulk > > dwc3-generic-peripheral usb@31000000: request 0000000099f219c0 was not queued to ep1in-bulk > > ``` > > > > the download is successful however, despite those error messages. Any idea? Is > > this related to this topic? > I have a feeling it is the UUU which should be fixed to not depend on the > ep1-in , really. > > You could however quickly try and apply the change in this patch not only to > SPL, but to U-Boot on your board as well, and see if those warnings > disappear. So, I did a quick test and the issue is still there. And looking better at the error now, this is about ep1in-bulk, that is not affected by this change at all. diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 477ecd020985..55b248505de5 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -1632,23 +1632,7 @@ usb_ep *dwc3_gadget_match_ep(struct usb_gadget *gadget, if (usb_endpoint_is_bulk_out(desc)) return dwc3_find_ep(gadget, "ep2out"); if (usb_endpoint_is_int_in(desc)) { - /* - * Special workaround for NXP UUU tool in SPL. - * - * The tool excepts the interrupt-in endpoint to be ep1in, - * otherwise it crashes. This is a result of the previous - * hard-coded EP setup in drivers/usb/gadget/epautoconf.c - * which did special-case EP allocation for SPL builds, - * and which was since converted to this callback, but - * without the special-case EP allocation in SPL part. - * - * This reinstates the SPL part in an isolated manner, - * only for NXP iMX SoCs, only for SPL builds, and only - * for the ep1in interrupt-in endpoint. - */ - if (IS_ENABLED(CONFIG_MACH_IMX) && IS_ENABLED(CONFIG_XPL_BUILD)) - return dwc3_find_ep(gadget, "ep1in"); - return dwc3_find_ep(gadget, "ep3in"); + return dwc3_find_ep(gadget, "ep1in"); } return NULL;