From: Tom Rini <trini@konsulko.com>
To: Simon Glass <sjg@chromium.org>
Cc: Jerome Forissier <jerome.forissier@linaro.org>,
U-Boot mailing list <u-boot@lists.denx.de>,
Adriano Cordova <adrianox@gmail.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Janne Grunau <j@jannau.net>,
Mattijs Korpershoek <mkorpershoek@baylibre.com>,
Yao Zi <ziyao@disroot.org>
Subject: Re: [RFC PATCH v1 1/7] efi_loader: make efi_exit_boot_services() call bootstage_report()
Date: Fri, 11 Apr 2025 12:46:11 -0600 [thread overview]
Message-ID: <20250411184611.GW5495@bill-the-cat> (raw)
In-Reply-To: <CAFLszThbA1fjziOrLFfRwFQ+aP=FZuF_M4cBYsnTZAqEMr8LTQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 807 bytes --]
On Fri, Apr 11, 2025 at 12:32:12PM -0600, Simon Glass wrote:
> Hi Jerome,
>
> On Fri, 11 Apr 2025 at 09:31, Jerome Forissier
> <jerome.forissier@linaro.org> wrote:
> >
> > CONFIG_BOOTSTAGE_REPORT is currently supported in the bootm command
> > only. Add support to the EFI boot.
> >
> > Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
> > ---
> >
> > lib/efi_loader/efi_boottime.c | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
>
> If you have time, could you take a look at unifying
> announce_and_cleanup() with the duplicate code in EFI?
And the duplicating code in arch/{arm,x86,riscv}. Maybe there's some
good place we can stick the bootstage calls, board_quiesce_devices() and
dm_remove_devices_active(). But maybe not, I'm not sure honestly.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2025-04-11 18:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-11 15:29 [RFC PATCH v1 0/7] Bootstage reports for CI Jerome Forissier
2025-04-11 15:29 ` [RFC PATCH v1 1/7] efi_loader: make efi_exit_boot_services() call bootstage_report() Jerome Forissier
2025-04-11 18:32 ` Simon Glass
2025-04-11 18:46 ` Tom Rini [this message]
2025-04-12 12:44 ` Simon Glass
2025-04-11 15:29 ` [RFC PATCH v1 2/7] bootstage: add support for reporting in JSON format Jerome Forissier
2025-04-11 15:29 ` [RFC PATCH v1 3/7] test/py/tests/test_bootstage.py: add test for JSON report Jerome Forissier
2025-04-11 15:29 ` [RFC PATCH v1 4/7] bootstage: add support for reporting in InfluxDB v2 line format Jerome Forissier
2025-04-11 15:29 ` [RFC PATCH v1 5/7] test/py/tests/test_bootstage.py: add test for InfluxDB report Jerome Forissier
2025-04-11 15:29 ` [RFC PATCH v1 6/7] sandbox64_defconfig: enable bootstage report in JSON and InfluxDB formats Jerome Forissier
2025-04-11 15:29 ` [RFC PATCH v1 7/7] test/py/tests/test_bootstage.py: upload bootstage data to InfluxDB cloud Jerome Forissier
2025-04-11 17:37 ` [RFC PATCH v1 0/7] Bootstage reports for CI Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250411184611.GW5495@bill-the-cat \
--to=trini@konsulko.com \
--cc=adrianox@gmail.com \
--cc=ilias.apalodimas@linaro.org \
--cc=j@jannau.net \
--cc=jerome.forissier@linaro.org \
--cc=mkorpershoek@baylibre.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
--cc=ziyao@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox