Re: [PATCH 00/13] video: Enhancements related to truetype and console

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 3072 bytes --]

On Fri, Apr 04, 2025 at 06:57:34AM +1300, Simon Glass wrote:
> Hi Tom,
> 
> On Thu, 3 Apr 2025 at 13:27, Tom Rini <trini@konsulko.com> wrote:
> >
> > On Thu, Apr 03, 2025 at 12:54:55PM +1300, Simon Glass wrote:
> > > Hi Tom,
> > >
> > > On Thu, 3 Apr 2025 at 10:11, Tom Rini <trini@konsulko.com> wrote:
> > > >
> > > > On Thu, Apr 03, 2025 at 08:19:03AM +1300, Simon Glass wrote:
> > > > > Hi Tom,
> > > > >
> > > > > On Thu, 3 Apr 2025 at 04:00, Tom Rini <trini@konsulko.com> wrote:
> > > > > >
> > > > > > On Wed, Apr 02, 2025 at 01:08:56PM +1300, Simon Glass wrote:
> > > > > > > Hi Tom,
> > > > > > >
> > > > > > > On Wed, 2 Apr 2025 at 10:41, Tom Rini <trini@konsulko.com> wrote:
> > > > > > > >
> > > > > > > > On Wed, Apr 02, 2025 at 06:29:31AM +1300, Simon Glass wrote:
> > > > > > > >
> > > > > > > > > This series includes some precursor patches needed for forthcoming expo
> > > > > > > > > enhancements.
> > > > > > > > >
> > > > > > > > > - truetype support for multiple lines
> > > > > > > > > - make white-on-black a runtime option
> > > > > > > > > - support drawing a rectangle
> > > > > > > > >
> > > > > > > > > This series was split out from schd2
> > > > > > > > [snip]
> > > > > > > > > base-commit: 3f76d803db9b500f43bc534465945a8d2836bb3e
> > > > > > > > > branch: schg
> > > > > > > >
> > > > > > > > I get as far as patch 4 before it doesn't apply to -next.
> > > > > > >
> > > > > > > Your tree is missing the video-damage series which adds some more
> > > > > > > tests. It is here if you want to pick it up:
> > > > > > >
> > > > > > > https://patchwork.ozlabs.org/project/uboot/list/?series=369663&state=*
> > > > > > >
> > > > > > > I can rebase and send a PR if you prefer.
> > > > > >
> > > > > > Reading the cover letter again, that doesn't seem ready to merge either.
> > > > >
> > > > > It seems OK to me. What are your concerns?
> > > >
> > > > The cover letter read to me like it should be further reworked to
> > > > address some of the problems it still has / exposed. That's likely why I
> > > > marked it as Changes Requested a year and a half ago.
> > >
> > > Which bit of it? Are you talking about my conversation with Alex, or
> > > the actual cover letter?
> >
> > Yes, I'm talking about the lengthy discussion in the cover letter which
> > sounds to me as a summary of "changes requested".
> 
> Perhaps we should talk about this on a call sometime. I was trying to
> understand why EFI has to sync the video after every character. I
> still think we could sync only when there is an EFI event, e.g. by
> hooking up cyclic, but in the end there wasn't really anything
> actionable for the series. Any such work would need some serious
> thought.
> 
> So if you are waiting on me to do something so that series can go in,
> let me know.

I went and got a second opinion, and they agreed with you, it's "apply
and enhance" not "changes requested". So yes, if you can send me a PR
against master for the video damage series, I'll take it, thanks.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]